From 76fc78e740beb78a454c8fbb71bb2c8d8783c92c Mon Sep 17 00:00:00 2001 From: Sunny Luo Date: Tue, 11 Dec 2018 13:25:36 -0800 Subject: [PATCH] Use relative path for SCRIPTDIR (#22598) Summary: Fixes https://github.com/facebook/react-native/issues/22521 The current approach has an issue with white spaces when compiling in Xcode 10.1 ![space](https://user-images.githubusercontent.com/615282/49782648-07836f80-fd52-11e8-952f-b93f8c593c60.png) Change back to relative path fixes this issue Pull Request resolved: https://github.com/facebook/react-native/pull/22598 Differential Revision: D13421446 Pulled By: hramos fbshipit-source-id: 688157b2e951399059cb6c95e2a6ce8d176e9b9c --- scripts/ios-install-third-party.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ios-install-third-party.sh b/scripts/ios-install-third-party.sh index ea9e67ce191..396867f785c 100755 --- a/scripts/ios-install-third-party.sh +++ b/scripts/ios-install-third-party.sh @@ -63,7 +63,7 @@ function fetch_and_unpack () { mkdir -p third-party -SCRIPTDIR=$(cd $(dirname "$0") && pwd) +SCRIPTDIR=$(dirname "$0") fetch_and_unpack glog-0.3.5.tar.gz https://github.com/google/glog/archive/v0.3.5.tar.gz 61067502c5f9769d111ea1ee3f74e6ddf0a5f9cc "\"$SCRIPTDIR/ios-configure-glog.sh\"" fetch_and_unpack double-conversion-1.1.6.tar.gz https://github.com/google/double-conversion/archive/v1.1.6.tar.gz 1c7d88afde3aaeb97bb652776c627b49e132e8e0