From 767462a910007dbf0f0e9bfb4ec34cd66c7ba728 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 10 Apr 2025 17:57:13 -0700 Subject: [PATCH] Introduce UseReactNativeNewArchitectureFeatureFlagDetector Summary: In this diff I'm introducing a new lint error called UseReactNativeNewArchitectureFeatureFlagDetector to prevent usages of: ``` ReactNativeFeatureFlags.enableBridgelessArchitecture ReactNativeFeatureFlags.enableFabricRenderer ReactNativeFeatureFlags.useFabricInterop ReactNativeFeatureFlags.useTurboModuleInterop ReactNativeFeatureFlags.useTurboModules ``` in favor of: ``` ReactNativeNewArchitectureFeatureFlags.enableBridgelessArchitecture ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer ReactNativeNewArchitectureFeatureFlags.useFabricInterop ReactNativeNewArchitectureFeatureFlags.useTurboModuleInterop ReactNativeNewArchitectureFeatureFlags.useTurboModules ``` changelog: [internal] internal Reviewed By: cortinico Differential Revision: D72028734 fbshipit-source-id: c9ca39133e3ce5e5f2d393e9b9ee1803b350bdad --- .../ReactNativeNewArchitectureFeatureFlags.kt | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlags.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlags.kt index 9d9967c785a..67feec91d24 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlags.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlags.kt @@ -7,9 +7,20 @@ package com.facebook.react.internal.featureflags +import android.annotation.SuppressLint import com.facebook.infer.annotation.Assertions import com.facebook.react.common.build.ReactBuildConfig +/** + * This class provides feature flags for the React Native New Architecture. It wraps the base + * ReactNativeFeatureFlags with additional logic for strict mode. When strict mode is enabled (via + * UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE), it enforces specific configurations and provides + * assertions to ensure proper setup. + * + * This class suppress the lint UseReactNativeNewArchitectureFeatureFlagDetector as it is expected + * to access ReactNativeFeatureFlags from this file. + */ +@SuppressLint("UseReactNativeNewArchitectureFeatureFlagDetector") public object ReactNativeNewArchitectureFeatureFlags { @JvmStatic