From 7562f9d6f501ce2f57153e4f62aed15e7ae4c709 Mon Sep 17 00:00:00 2001 From: Dave Miller Date: Wed, 6 Jul 2016 09:30:13 -0700 Subject: [PATCH] Fix padding with Text on Android Summary: @public Text was not correctly respecting padding. We would account for it when measuring, but then not actually apply the padding to the text. This adds support for proper padding Reviewed By: andreicoman11 Differential Revision: D3516692 --- .../src/main/java/com/facebook/react/flat/RCTTextInput.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java b/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java index c8bfa3e1b6e..2319d8ec796 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java @@ -124,7 +124,8 @@ public class RCTTextInput extends RCTVirtualText implements AndroidView, CSSNode public void onCollectExtraUpdates(UIViewOperationQueue uiViewOperationQueue) { super.onCollectExtraUpdates(uiViewOperationQueue); if (mJsEventCount != UNSET) { - ReactTextUpdate reactTextUpdate = new ReactTextUpdate(getText(), mJsEventCount, false); + ReactTextUpdate reactTextUpdate = + new ReactTextUpdate(getText(), mJsEventCount, false, getPadding()); uiViewOperationQueue.enqueueUpdateExtraData(getReactTag(), reactTextUpdate); } }