From 74026041baa5467d990a9d38385fea92a5f947cb Mon Sep 17 00:00:00 2001 From: Joshua Gross Date: Thu, 30 Jan 2020 17:37:28 -0800 Subject: [PATCH] Fix AndroidTextInput C++ debugging code Summary: Fixes debug output for AndroidTextInput. Failed to compile (in special "Fabric debug mode") before. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D19653093 fbshipit-source-id: 887916892a78a4e40bb4f6154f474add9672edfb --- .../textinput/androidtextinput/AndroidTextInputProps.cpp | 2 +- .../textinput/androidtextinput/AndroidTextInputProps.h | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ReactCommon/fabric/components/textinput/androidtextinput/AndroidTextInputProps.cpp b/ReactCommon/fabric/components/textinput/androidtextinput/AndroidTextInputProps.cpp index 5f25f17da9e..09d8e1506cb 100644 --- a/ReactCommon/fabric/components/textinput/androidtextinput/AndroidTextInputProps.cpp +++ b/ReactCommon/fabric/components/textinput/androidtextinput/AndroidTextInputProps.cpp @@ -283,7 +283,7 @@ folly::dynamic AndroidTextInputProps::getDynamic() const { #if RN_DEBUG_STRING_CONVERTIBLE // TODO: codegen these -SharedDebugStringConvertibleList TextProps::getDebugProps() const { +SharedDebugStringConvertibleList AndroidTextInputProps::getDebugProps() const { return {}; } #endif diff --git a/ReactCommon/fabric/components/textinput/androidtextinput/AndroidTextInputProps.h b/ReactCommon/fabric/components/textinput/androidtextinput/AndroidTextInputProps.h index deb9014fe8e..7fb58b0ddc0 100644 --- a/ReactCommon/fabric/components/textinput/androidtextinput/AndroidTextInputProps.h +++ b/ReactCommon/fabric/components/textinput/androidtextinput/AndroidTextInputProps.h @@ -158,6 +158,10 @@ class AndroidTextInputProps final : public ViewProps, public BaseTextProps { * paragraph. */ ParagraphAttributes const paragraphAttributes{}; + +#if RN_DEBUG_STRING_CONVERTIBLE + SharedDebugStringConvertibleList getDebugProps() const; +#endif }; } // namespace react