From 73eb6c2481d7d2dd16a2ae4341ff9eb8477db688 Mon Sep 17 00:00:00 2001 From: Mike Grabowski Date: Thu, 12 Oct 2017 08:51:31 -0700 Subject: [PATCH] Fix failing flow tests Summary: Metro Bundler ships with `react_native_fb` flow annotations whereas our repo is set to ignore `react_native_oss` flow issues. For now, a hot fix is to make our repo ignore both. Detailed discussion happens here: https://github.com/facebook/metro-bundler/commit/87cfc05ea67e19c367e24e644915b49024ce3f2a#commitcomment-24884835 Those changes have been applied to `0.50.0-rc.0` in order to make it green. Closes https://github.com/facebook/react-native/pull/16310 Differential Revision: D6031378 Pulled By: hramos fbshipit-source-id: 491d866bb35bd6c30a27dbc04586b15144a8efb2 --- .flowconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.flowconfig b/.flowconfig index 6ceb63fe5af..8556171249f 100644 --- a/.flowconfig +++ b/.flowconfig @@ -46,8 +46,8 @@ suppress_type=$FlowFixMeProps suppress_type=$FlowFixMeState suppress_type=$FixMe -suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-6]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\) -suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-6]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+ +suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-6]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*[react_native_oss|react_native_fb][a-z,_]*\\)?)\\) +suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-6]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*[react_native_oss|react_native_fb][a-z,_]*\\)?)\\)?:? #[0-9]+ suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError