From 73778b3e80c3110da72f6c8b369c840222c7410a Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Wed, 2 Sep 2026 01:27:17 -0700 Subject: [PATCH] Cover `react/renderer/animations` with guards (#58185) Summary: Pull Request resolved: https://github.com/react/react-native/pull/58185 Classifies `react/renderer/animations:animations` as a "for frameworks" target under the C++ stable API three-tier visibility model. Adds `#include ` to the module's six exported headers (`LayoutAnimationCallbackWrapper.h`, `LayoutAnimationDriver.h`, `LayoutAnimationKeyFrameManager.h`, `conversions.h`, `primitives.h`, `utils.h`), and wires the guard dependency into BUCK and CMake. No CocoaPods change is needed: the module ships as a subspec of `React-Fabric`, whose parent spec already declares `React-cxxstableapi` and calls `mark_as_react_native_build`. Consumers that opt into `RN_STRICT_API` now get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D117863703 fbshipit-source-id: 8fedc2e3e56cffa0e56b5d6df66628750d734314 --- .../ReactCommon/react/renderer/animations/CMakeLists.txt | 1 + .../react/renderer/animations/LayoutAnimationCallbackWrapper.h | 2 ++ .../react/renderer/animations/LayoutAnimationDriver.h | 2 ++ .../react/renderer/animations/LayoutAnimationKeyFrameManager.h | 2 ++ .../ReactCommon/react/renderer/animations/conversions.h | 2 ++ .../ReactCommon/react/renderer/animations/primitives.h | 2 ++ .../react-native/ReactCommon/react/renderer/animations/utils.h | 2 ++ 7 files changed, 13 insertions(+) diff --git a/packages/react-native/ReactCommon/react/renderer/animations/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/animations/CMakeLists.txt index a29c773ca89..377d8de9e26 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/animations/CMakeLists.txt @@ -18,6 +18,7 @@ target_link_libraries(react_renderer_animations glog glog_init jsi + react_cxxstableapi react_debug react_renderer_componentregistry react_renderer_core diff --git a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationCallbackWrapper.h b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationCallbackWrapper.h index 53ba7915c49..69eab497b71 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationCallbackWrapper.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationCallbackWrapper.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h index 7e22dfe8d15..9fb2f666201 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h index 977be17b0a4..9edf8e71301 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/conversions.h b/packages/react-native/ReactCommon/react/renderer/animations/conversions.h index 1eb38ae2822..f72700004c5 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/conversions.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/conversions.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/primitives.h b/packages/react-native/ReactCommon/react/renderer/animations/primitives.h index b43c53474fb..289bc634e4e 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/primitives.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/primitives.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/utils.h b/packages/react-native/ReactCommon/react/renderer/animations/utils.h index 1f471d0d0a9..9f1bb4d8349 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/utils.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/utils.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include