From 72dae519d05ef4e9f0938d032e09409232836e01 Mon Sep 17 00:00:00 2001 From: Sebastian Lund Date: Mon, 7 Aug 2017 06:57:56 -0700 Subject: [PATCH] Expose didCloseWithCode in RCTReconnectingWebSocket Summary: Expose didCloseWithCode in RCTReconnectingWebSocket in order to get notified when the reconnecting websocket is closed by the end-point. Reviewed By: javache Differential Revision: D5573394 fbshipit-source-id: 78bffeb98c6bf32b059194fc07ffc1f0a7bf4aae --- Libraries/WebSocket/RCTReconnectingWebSocket.h | 2 ++ Libraries/WebSocket/RCTReconnectingWebSocket.m | 1 + Libraries/WebSocket/RCTWebSocketObserver.m | 4 ++++ React/DevSupport/RCTPackagerConnection.m | 4 ++++ 4 files changed, 11 insertions(+) diff --git a/Libraries/WebSocket/RCTReconnectingWebSocket.h b/Libraries/WebSocket/RCTReconnectingWebSocket.h index 4d15d067929..af61f81d15d 100644 --- a/Libraries/WebSocket/RCTReconnectingWebSocket.h +++ b/Libraries/WebSocket/RCTReconnectingWebSocket.h @@ -17,6 +17,8 @@ - (void)webSocket:(RCTSRWebSocket *)webSocket didReceiveMessage:(id)message; +- (void)webSocket:(RCTSRWebSocket *)webSocket didCloseWithCode:(NSInteger)code reason:(NSString *)reason wasClean:(BOOL)wasClean; + @end @interface RCTReconnectingWebSocket : NSObject diff --git a/Libraries/WebSocket/RCTReconnectingWebSocket.m b/Libraries/WebSocket/RCTReconnectingWebSocket.m index a3caa41c9ae..d57cab50dd7 100644 --- a/Libraries/WebSocket/RCTReconnectingWebSocket.m +++ b/Libraries/WebSocket/RCTReconnectingWebSocket.m @@ -80,6 +80,7 @@ - (void)webSocket:(RCTSRWebSocket *)webSocket didCloseWithCode:(NSInteger)code reason:(NSString *)reason wasClean:(BOOL)wasClean { + [self.delegate webSocket:webSocket didCloseWithCode:code reason:reason wasClean:wasClean]; [self reconnect]; } diff --git a/Libraries/WebSocket/RCTWebSocketObserver.m b/Libraries/WebSocket/RCTWebSocketObserver.m index 04bc7e70ced..fc4d9d4002e 100644 --- a/Libraries/WebSocket/RCTWebSocketObserver.m +++ b/Libraries/WebSocket/RCTWebSocketObserver.m @@ -61,6 +61,10 @@ } } +- (void)webSocket:(RCTSRWebSocket *)webSocket didCloseWithCode:(NSInteger)code reason:(NSString *)reason wasClean:(BOOL)wasClean +{ +} + @end #endif diff --git a/React/DevSupport/RCTPackagerConnection.m b/React/DevSupport/RCTPackagerConnection.m index 66de385a23f..2be5de35402 100644 --- a/React/DevSupport/RCTPackagerConnection.m +++ b/React/DevSupport/RCTPackagerConnection.m @@ -133,6 +133,10 @@ static BOOL isSupportedVersion(NSNumber *version) } } +- (void)webSocket:(RCTSRWebSocket *)webSocket didCloseWithCode:(NSInteger)code reason:(NSString *)reason wasClean:(BOOL)wasClean +{ +} + @end #endif