Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup TextLayoutManager

Browse Source 
Summary: Easy cleanup of commented code in TextLayoutManager, I kept the TODOs to complete the code in the future

Reviewed By: shergin

Differential Revision: D14372356

fbshipit-source-id: ff87f9b09e9f40ed021256f463e39299467b3e0e
This commit is contained in:
David Vacca
2019-03-11 19:24:06 -07:00
committed by Facebook Github Bot
parent 36957dcedd
commit 726d001210
1 changed files with 2 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java
+2 -32
View File
@@ -63,24 +63,7 @@ public class TextLayoutManager {
fragment.getString("string"),
textAttributes.mTextTransform));
// TODO: add support for TextInlineImage and BaseText
// if (child instanceof ReactRawTextShadowNode) {
// sb.append(((ReactRawTextShadowNode) child).getText());
// } else if (child instanceof ReactBaseTextShadowNode) {
// buildSpannableFromFragment((ReactBaseTextShadowNode) child, sb, ops);
// } else if (child instanceof ReactTextInlineImageShadowNode) {
// // We make the image take up 1 character in the span and put a corresponding character into
// // the text so that the image doesn't run over any following text.
// sb.append(INLINE_IMAGE_PLACEHOLDER);
// ops.add(
// new SetSpanOperation(
// sb.length() - INLINE_IMAGE_PLACEHOLDER.length(),
// sb.length(),
// ((ReactTextInlineImageShadowNode) child).buildInlineImageSpan()));
// } else {
// throw new IllegalViewOperationException(
// "Unexpected view type nested under text node: " + child.getClass());
// }
// TODO: add support for TextInlineImage and BaseText
int end = sb.length();
if (end >= start) {
@@ -179,23 +162,10 @@ public class TextLayoutManager {
buildSpannableFromFragment(context, attributedString.getArray("fragments"), sb, ops);
// TODO T31905686: add support for inline Images
// textShadowNode.mContainsImages = false;
// textShadowNode.mHeightOfTallestInlineImage = Float.NaN;
// TODO T31905686: add support for inline Images
// While setting the Spans on the final text, we also check whether any of them are images.
int priority = 0;
for (SetSpanOperation op : ops) {
// TODO T31905686: add support for TextInlineImage in C++
// if (op.what instanceof TextInlineImageSpan) {
// int height = ((TextInlineImageSpan) op.what).getHeight();
// textShadowNode.mContainsImages = true;
// if (Float.isNaN(textShadowNode.mHeightOfTallestInlineImage)
// || height > textShadowNode.mHeightOfTallestInlineImage) {
// textShadowNode.mHeightOfTallestInlineImage = height;
// }
// }
// Actual order of calling {@code execute} does NOT matter,
// but the {@code priority} DOES matter.
op.execute(sb, priority);