From 726a4a1e5ef3bc8034a068145da2bb94ae3acfaa Mon Sep 17 00:00:00 2001 From: Sergei Rybalkin Date: Thu, 13 Jun 2024 07:20:18 -0700 Subject: [PATCH] Revert D57681447: Expose DevSettings.openDebugger method to JS Differential Revision: D57681447 Original commit changeset: ddb1fbd0f1c8 Original Phabricator Diff: D57681447 fbshipit-source-id: 94bf94227bcc9fab8282bd68ddf3f4f1df64656b --- .../react-native/React/CoreModules/RCTDevSettings.mm | 12 ------------ .../react/modules/debug/DevSettingsModule.kt | 4 ---- .../src/private/specs/modules/NativeDevSettings.js | 1 - 3 files changed, 17 deletions(-) diff --git a/packages/react-native/React/CoreModules/RCTDevSettings.mm b/packages/react-native/React/CoreModules/RCTDevSettings.mm index d4e8473146e..887a69c06c1 100644 --- a/packages/react-native/React/CoreModules/RCTDevSettings.mm +++ b/packages/react-native/React/CoreModules/RCTDevSettings.mm @@ -501,15 +501,6 @@ RCT_EXPORT_METHOD(addMenuItem : (NSString *)title) } } -RCT_EXPORT_METHOD(openDebugger) -{ -#if RCT_ENABLE_INSPECTOR - [RCTInspectorDevServerHelper - openDebugger:self.bundleManager.bundleURL - withErrorMessage:@"Failed to open debugger. Please check that the dev server is running and reload the app."]; -#endif -} - #pragma mark - Internal /** @@ -617,9 +608,6 @@ RCT_EXPORT_METHOD(openDebugger) - (void)setupHMRClientWithAdditionalBundleURL:(NSURL *)bundleURL { } -- (void)openDebugger -{ -} - (void)addMenuItem:(NSString *)title { } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/debug/DevSettingsModule.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/debug/DevSettingsModule.kt index a482235ab83..258f8042c5f 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/debug/DevSettingsModule.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/debug/DevSettingsModule.kt @@ -61,10 +61,6 @@ public class DevSettingsModule( } } - override fun openDebugger() { - devSupportManager.openDebugger() - } - override fun setIsShakeToShowDevMenuEnabled(enabled: Boolean) { // iOS only } diff --git a/packages/react-native/src/private/specs/modules/NativeDevSettings.js b/packages/react-native/src/private/specs/modules/NativeDevSettings.js index 2afb1d54f36..26085ad6bc3 100644 --- a/packages/react-native/src/private/specs/modules/NativeDevSettings.js +++ b/packages/react-native/src/private/specs/modules/NativeDevSettings.js @@ -21,7 +21,6 @@ export interface Spec extends TurboModule { +setProfilingEnabled: (isProfilingEnabled: boolean) => void; +toggleElementInspector: () => void; +addMenuItem: (title: string) => void; - +openDebugger?: () => void; // Events +addListener: (eventName: string) => void;