From 7244bae47d8f336d5195df9f225b9fe70c80a193 Mon Sep 17 00:00:00 2001 From: Emily Janzer Date: Wed, 24 Jul 2019 20:11:37 -0700 Subject: [PATCH] Rename addRootView to startSurface Summary: I'm only renaming the new `addRootView` that I added (which takes the moduleName, and uses startSurfaceWithConstraints), since the other one implements the UIManager interface method that's shared with paper. Reviewed By: shergin Differential Revision: D16432425 fbshipit-source-id: 392af42690052551504676df776bac6d1a968785 --- .../main/java/com/facebook/react/fabric/FabricUIManager.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java index c6a907ade9b..bd001b0863e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java @@ -138,11 +138,12 @@ public class FabricUIManager implements UIManager, LifecycleEventListener { mReactApplicationContext.addLifecycleEventListener(this); } + // TODO (T47819352): Rename this to startSurface for consistency with xplat/iOS @Override public int addRootView( final T rootView, final WritableMap initialProps, final @Nullable String initialUITemplate) { final int rootTag = ReactRootViewTagGenerator.getNextRootViewTag(); - // TODO T31905686: Refactor both addRootView methods into one method + // TODO T31905686: Combine with startSurface below ThemedReactContext reactContext = new ThemedReactContext(mReactApplicationContext, rootView.getContext()); mMountingManager.addRootView(rootTag, rootView); @@ -158,7 +159,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener { return rootTag; } - public int addRootView( + public int startSurface( final T rootView, final String moduleName, final WritableMap initialProps,