mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix hermes-engine Xcode integration (#38896)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/38896 This diff fixes a typo in hermes-engine build scripts input/output files. This typo prevented execution of `[RN] [1] Build Hermesc` build script in certain scenarios. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D48192671 fbshipit-source-id: 5a3b7d5dfd66f36328ef1941a40f4ecb47fb9054
This commit is contained in:
committed by
Facebook GitHub Bot
parent
30ab7a45ec
commit
71a384072c
@@ -115,7 +115,7 @@ Pod::Spec.new do |spec|
|
||||
{
|
||||
:name => '[RN] [1] Build Hermesc',
|
||||
:output_files => [
|
||||
"${PODS_ROOT}/hermes_engine/build_host_hermesc/ImportHermesc.cmake"
|
||||
"#{hermesc_path}/ImportHermesc.cmake"
|
||||
],
|
||||
:script => <<-EOS
|
||||
. "${REACT_NATIVE_PATH}/scripts/xcode/with-environment.sh"
|
||||
@@ -125,7 +125,7 @@ Pod::Spec.new do |spec|
|
||||
},
|
||||
{
|
||||
:name => '[RN] [2] Build Hermes',
|
||||
:input_files => ["${PODS_ROOT}/hermes_engine/build_host_hermesc/ImportHermesc.cmake"],
|
||||
:input_files => ["#{hermesc_path}/ImportHermesc.cmake"],
|
||||
:output_files => [
|
||||
"${PODS_ROOT}/hermes-engine/build/iphonesimulator/API/hermes/hermes.framework/hermes"
|
||||
],
|
||||
|
||||
Reference in New Issue
Block a user