From 6f8a27d0c38f0cd315c23d1eae22b296552a230f Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 27 Mar 2025 13:26:19 -0700 Subject: [PATCH] Fix AssertionError:com.facebook.react.views.text.ReactTextView.onLayout in legacy architecture (#50336) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/50336 This diff is fixin an assertion error being triggered in ReactTextView: ` AssertionError:com.facebook.react.views.text.ReactTextView.onLayout ` changelog: [internal] internal Reviewed By: Abbondanzo Differential Revision: D71990566 fbshipit-source-id: f94b27252ae62472544369ab285d72bc35ec8afc --- .../java/com/facebook/react/views/text/ReactTextView.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java index 0d3aaf8c4c3..895aafc30c6 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java @@ -34,7 +34,6 @@ import com.facebook.common.logging.FLog; import com.facebook.infer.annotation.Assertions; import com.facebook.react.bridge.Arguments; import com.facebook.react.bridge.ReactContext; -import com.facebook.react.bridge.UIManager; import com.facebook.react.bridge.WritableArray; import com.facebook.react.bridge.WritableMap; import com.facebook.react.common.ReactConstants; @@ -45,7 +44,7 @@ import com.facebook.react.uimanager.LengthPercentage; import com.facebook.react.uimanager.LengthPercentageType; import com.facebook.react.uimanager.PixelUtil; import com.facebook.react.uimanager.ReactCompoundView; -import com.facebook.react.uimanager.UIManagerHelper; +import com.facebook.react.uimanager.UIManagerModule; import com.facebook.react.uimanager.ViewDefaults; import com.facebook.react.uimanager.common.UIManagerType; import com.facebook.react.uimanager.common.ViewUtil; @@ -216,8 +215,8 @@ public class ReactTextView extends AppCompatTextView implements ReactCompoundVie } ReactContext reactContext = getReactContext(); - UIManager uiManager = - Assertions.assertNotNull(UIManagerHelper.getUIManager(reactContext, UIManagerType.LEGACY)); + UIManagerModule uiManager = + Assertions.assertNotNull(reactContext.getNativeModule(UIManagerModule.class)); Spanned text = (Spanned) getText(); Layout layout = getLayout();