From 6d50defa284c64ba314dfb8b3683b667749c7e86 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Wed, 10 Jun 2026 09:17:52 -0700 Subject: [PATCH] Remove dead HostTargetController::installPerfIssuesBinding declaration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: X-link: https://github.com/facebook/react-native/pull/57145 `HostTargetController::installPerfIssuesBinding()` was declared in `jsinspector-modern/HostTarget.h` but had no definition anywhere and no callers. (`HostTargetController` is `final`, so the method is not an override.) A declared-but-never-defined non-virtual member cannot be invoked — any call would be a link error — so this is unreachable dead code. The unrelated, live `HostTarget::installPerfIssuesBinding` (a different class) is left intact. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D108012907 fbshipit-source-id: 5c7f14a7956f67e3e884a32f95aa2e50fd0f3ea6 --- .../ReactCommon/jsinspector-modern/HostTarget.h | 7 ------- scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api | 1 - 10 files changed, 16 deletions(-) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/HostTarget.h b/packages/react-native/ReactCommon/jsinspector-modern/HostTarget.h index 55194fc98b6..7d0193d3108 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/HostTarget.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/HostTarget.h @@ -252,13 +252,6 @@ class HostTargetController final { bool hasInstance() const; - /** - * [Experimental] Install a runtime binding subscribing to new Performance - * Issues, which we broadcast to the V2 Perf Monitor overlay via - * \ref HostTargetDelegate::unstable_onPerfIssueAdded. - */ - void installPerfIssuesBinding(); - /** * Increments the target's pause overlay counter. The counter represents the * exact number of Agents that have (concurrently) requested the pause diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index 032f7dd1c76..50cc8ffa636 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -10514,7 +10514,6 @@ class facebook::react::jsinspector_modern::HostTargetController { public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate(); public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing(); public void incrementPauseOverlayCounter(); - public void installPerfIssuesBinding(); } class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate { diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api index 8567ff90b3b..15af52e85c1 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api @@ -10138,7 +10138,6 @@ class facebook::react::jsinspector_modern::HostTargetController { public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate(); public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing(); public void incrementPauseOverlayCounter(); - public void installPerfIssuesBinding(); } class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate { diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index 59d13ef8962..31a38536d0e 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -10367,7 +10367,6 @@ class facebook::react::jsinspector_modern::HostTargetController { public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate(); public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing(); public void incrementPauseOverlayCounter(); - public void installPerfIssuesBinding(); } class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate { diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api index 16b939771c8..792486ffbca 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api @@ -12408,7 +12408,6 @@ class facebook::react::jsinspector_modern::HostTargetController { public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate(); public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing(); public void incrementPauseOverlayCounter(); - public void installPerfIssuesBinding(); } class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate { diff --git a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api index fbd21d7e138..6fe831004af 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api @@ -12094,7 +12094,6 @@ class facebook::react::jsinspector_modern::HostTargetController { public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate(); public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing(); public void incrementPauseOverlayCounter(); - public void installPerfIssuesBinding(); } class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate { diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api index 024be03a5fa..bc8c689c21f 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api @@ -12271,7 +12271,6 @@ class facebook::react::jsinspector_modern::HostTargetController { public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate(); public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing(); public void incrementPauseOverlayCounter(); - public void installPerfIssuesBinding(); } class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate { diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api index 9463e781a00..614933f01ac 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api @@ -7569,7 +7569,6 @@ class facebook::react::jsinspector_modern::HostTargetController { public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate(); public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing(); public void incrementPauseOverlayCounter(); - public void installPerfIssuesBinding(); } class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate { diff --git a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api index cc246d15c81..9cc07759abe 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api @@ -7395,7 +7395,6 @@ class facebook::react::jsinspector_modern::HostTargetController { public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate(); public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing(); public void incrementPauseOverlayCounter(); - public void installPerfIssuesBinding(); } class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate { diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api index caa722b7836..b73fc36efc9 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api @@ -7560,7 +7560,6 @@ class facebook::react::jsinspector_modern::HostTargetController { public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate(); public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing(); public void incrementPauseOverlayCounter(); - public void installPerfIssuesBinding(); } class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {