From 6b2596d1879e05457ffccbe7a3a0cc9f6a054f55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20Norte?= Date: Thu, 13 Apr 2023 09:19:00 -0700 Subject: [PATCH] Implement offsetWidth and offsetHeight Summary: These can just be derived from `getBoundingClientRect`. The only difference is that they're always integers (so we do we rounding manually in JS). They're implemented as defined in as defined in https://github.com/react-native-community/discussions-and-proposals/pull/607. Changelog: [internal] bypass-github-export-checks Reviewed By: sammy-SC Differential Revision: D44512595 fbshipit-source-id: 0d994135efbb77740a06ea37eb1e6aeddde1af6e --- .../react-native/Libraries/DOM/Nodes/ReactNativeElement.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native/Libraries/DOM/Nodes/ReactNativeElement.js b/packages/react-native/Libraries/DOM/Nodes/ReactNativeElement.js index 99dbff9956b..f76e57b3d55 100644 --- a/packages/react-native/Libraries/DOM/Nodes/ReactNativeElement.js +++ b/packages/react-native/Libraries/DOM/Nodes/ReactNativeElement.js @@ -55,7 +55,7 @@ export default class ReactNativeElement } get offsetHeight(): number { - throw new TypeError('Unimplemented'); + return Math.round(this.getBoundingClientRect().height); } get offsetLeft(): number { @@ -71,7 +71,7 @@ export default class ReactNativeElement } get offsetWidth(): number { - throw new TypeError('Unimplemented'); + return Math.round(this.getBoundingClientRect().width); } /**