From 6ab5bb6869284d78e889b6892027c542d3ef4f3c Mon Sep 17 00:00:00 2001 From: David Vacca Date: Tue, 15 Feb 2022 15:20:24 -0800 Subject: [PATCH] Rename ReactNativeConfig.getInt64 -> ReactNativeConfig.getLong Summary: In this I'm renaming ReactNativeConfig.getInt64 -> ReactNativeConfig.getLong changelog: [internal] internal Reviewed By: javache, philIip Differential Revision: D33901536 fbshipit-source-id: 688aff9a849299eb8ad904b75b03d7fb5f0d8172 --- .../com/facebook/react/fabric/EmptyReactNativeConfig.java | 2 +- .../java/com/facebook/react/fabric/ReactNativeConfig.java | 4 ++-- .../com/facebook/react/fabric/jni/ReactNativeConfigHolder.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/EmptyReactNativeConfig.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/EmptyReactNativeConfig.java index ce34e5b3c51..e068e3f4d1d 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/EmptyReactNativeConfig.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/EmptyReactNativeConfig.java @@ -19,7 +19,7 @@ public class EmptyReactNativeConfig implements ReactNativeConfig { } @Override - public int getInt64(final String s) { + public long getInt64(final String s) { return 0; } diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/ReactNativeConfig.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/ReactNativeConfig.java index b4938fb572e..87f563cced3 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/ReactNativeConfig.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/ReactNativeConfig.java @@ -31,12 +31,12 @@ public interface ReactNativeConfig { boolean getBool(@NonNull String param); /** - * Get an integer param by string name. Default should be 0. + * Get a Long param by string name. Default should be 0. * * @param param The string name of the parameter being requested. */ @DoNotStrip - int getInt64(@NonNull String param); + long getInt64(@NonNull String param); /** * Get a string param by string name. Default should be "", empty string. diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/ReactNativeConfigHolder.cpp b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/ReactNativeConfigHolder.cpp index 8e158a775ef..72686b02b40 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/ReactNativeConfigHolder.cpp +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/ReactNativeConfigHolder.cpp @@ -29,7 +29,7 @@ std::string ReactNativeConfigHolder::getString(const std::string ¶m) const { int64_t ReactNativeConfigHolder::getInt64(const std::string ¶m) const { static const auto method = facebook::jni::findClassStatic( "com/facebook/react/fabric/ReactNativeConfig") - ->getMethod("getInt64"); + ->getMethod("getInt64"); return method(reactNativeConfig_, facebook::jni::make_jstring(param).get()); }