From 6a6590fbdfd0266f2d5b90552de3279b4b57b24f Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 13 Mar 2020 22:10:27 -0700 Subject: [PATCH] Fix bug in TextInlineViews when using a deep nested hierarchy of Text and Images Summary: This fixes a bug in Android TextInlineViews that was reproducible in ActivityLog screen, see T63438920 Since Text are virtual nodes it is not necessary for these kind of views to stack views during diffing. changelog: [internal] Reviewed By: shergin Differential Revision: D20448085 fbshipit-source-id: 2d852975493bf6bcc7840c80c5de5cb5f7890303 --- ReactCommon/fabric/components/text/text/TextShadowNode.h | 1 - 1 file changed, 1 deletion(-) diff --git a/ReactCommon/fabric/components/text/text/TextShadowNode.h b/ReactCommon/fabric/components/text/text/TextShadowNode.h index 55b24ca12c8..76d333223ab 100644 --- a/ReactCommon/fabric/components/text/text/TextShadowNode.h +++ b/ReactCommon/fabric/components/text/text/TextShadowNode.h @@ -33,7 +33,6 @@ class TextShadowNode : public ConcreteShadowNode< #ifdef ANDROID traits.set(ShadowNodeTraits::Trait::FormsView); - traits.set(ShadowNodeTraits::Trait::FormsStackingContext); #endif return traits;