Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: remove LocalData from ShadowView

Browse Source 
Summary:
LocalData isn't used by any components. We've moved towards State.
Changelog: [internal]

Reviewed By: mdvacca

Differential Revision: D19250737

fbshipit-source-id: 10bf0b62ffad01ad10b07d029e84df4f312780a1
This commit is contained in:
Samuel Susla
2020-01-20 05:48:31 -08:00
committed by Facebook Github Bot
parent 9948fbdeec
commit 6a128bd810
3 changed files with 0 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp
-34
View File
@@ -426,29 +426,6 @@ local_ref<JMountItem::javaobject> createInsertMountItem(
mutation.index);
}
local_ref<JMountItem::javaobject> createUpdateLocalData(
const jni::global_ref<jobject> &javaUIManager,
const ShadowViewMutation &mutation) {
static auto updateLocalDataInstruction =
jni::findClassStatic(UIManagerJavaDescriptor)
->getMethod<alias_ref<JMountItem>(jint, ReadableMap::javaobject)>(
"updateLocalDataMountItem");
auto localData = mutation.newChildShadowView.localData;
folly::dynamic newLocalData = folly::dynamic::object();
if (localData) {
newLocalData = localData->getDynamic();
}
local_ref<ReadableNativeMap::jhybridobject> readableNativeMap =
ReadableNativeMap::newObjectCxxArgs(newLocalData);
return updateLocalDataInstruction(
javaUIManager,
mutation.newChildShadowView.tag,
castReadableMap(readableNativeMap).get());
}
local_ref<JMountItem::javaobject> createUpdateStateMountItem(
const jni::global_ref<jobject> &javaUIManager,
const ShadowViewMutation &mutation) {
@@ -737,11 +714,6 @@ void Binding::schedulerDidFinishTransaction(
mountItems[position++] =
createUpdatePropsMountItem(localJavaUIManager, mutation);
}
if (mutation.oldChildShadowView.localData !=
mutation.newChildShadowView.localData) {
mountItems[position++] =
createUpdateLocalData(localJavaUIManager, mutation);
}
if (mutation.oldChildShadowView.state !=
mutation.newChildShadowView.state) {
mountItems[position++] =
@@ -791,12 +763,6 @@ void Binding::schedulerDidFinishTransaction(
createUpdateStateMountItem(localJavaUIManager, mutation);
}
// LocalData
if (mutation.newChildShadowView.localData) {
mountItems[position++] =
createUpdateLocalData(localJavaUIManager, mutation);
}
// Layout
auto updateLayoutMountItem =
createUpdateLayoutMountItem(localJavaUIManager, mutation);