From 69e4252ccba4d76476194dcff377b65099212928 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Mon, 30 Jun 2025 13:22:36 -0700 Subject: [PATCH] Fix access to observers outside lock in ImageResponseObserverCoordinator (#52346) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/52346 This is bypassing the mutex, and potentially not thread-safe. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D77541041 fbshipit-source-id: f97415d066786864806836768dbce2d5e68487ef --- .../renderer/imagemanager/ImageResponseObserverCoordinator.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponseObserverCoordinator.cpp b/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponseObserverCoordinator.cpp index cbc8995fd79..5b3e2574a9f 100644 --- a/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponseObserverCoordinator.cpp +++ b/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponseObserverCoordinator.cpp @@ -95,7 +95,7 @@ void ImageResponseObserverCoordinator::nativeImageResponseComplete( auto observers = observers_; mutex_.unlock(); - for (auto observer : observers_) { + for (auto observer : observers) { observer->didReceiveImage(imageResponse); } }