From 69b17ff48e58967a25599bc4d28d39e8101d26f6 Mon Sep 17 00:00:00 2001 From: Yao Bin Date: Fri, 6 Jan 2017 15:37:24 -0800 Subject: [PATCH] Update SignedAPKAndroid.md Summary: Update docs to prevent build process from failing when collaborators do not have MYAPP_RELEASE_STORE_FILE in their env. Build process often fails when following the existing documentation on setting the signingConfigs in build.gradle, as not all collaborators have the required ENV set in their gradle.properties Closes https://github.com/facebook/react-native/pull/11716 Differential Revision: D4389150 Pulled By: hramos fbshipit-source-id: 37941382950fac41f19d19317f49769588b135b4 --- docs/SignedAPKAndroid.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/docs/SignedAPKAndroid.md b/docs/SignedAPKAndroid.md index 4b108a69dcd..2a5df0666ee 100644 --- a/docs/SignedAPKAndroid.md +++ b/docs/SignedAPKAndroid.md @@ -54,10 +54,12 @@ android { defaultConfig { ... } signingConfigs { release { - storeFile file(MYAPP_RELEASE_STORE_FILE) - storePassword MYAPP_RELEASE_STORE_PASSWORD - keyAlias MYAPP_RELEASE_KEY_ALIAS - keyPassword MYAPP_RELEASE_KEY_PASSWORD + if (project.hasProperty('MYAPP_RELEASE_STORE_FILE')) { + storeFile file(MYAPP_RELEASE_STORE_FILE) + storePassword MYAPP_RELEASE_STORE_PASSWORD + keyAlias MYAPP_RELEASE_KEY_ALIAS + keyPassword MYAPP_RELEASE_KEY_PASSWORD + } } } buildTypes {