From 6802eb92ffda72fdf26d2e0afe4f06ffb59e67b8 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Thu, 12 Feb 2026 06:59:33 -0800 Subject: [PATCH] Move RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION to its only consumer (#55528) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/55528 Move the RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION define from RCTDefines.h to RCTDevSettings.mm, which is its only consumer. This removes a __has_include dependency from the shared header, making RCTDefines.h usable as a standalone lightweight target without pulling in RCTPackagerConnection.h. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D93018381 fbshipit-source-id: bff276bb788197bb59a7f4626cc355d85a8dea87 --- packages/react-native/React/Base/RCTDefines.h | 8 -------- packages/react-native/React/CoreModules/RCTDevSettings.mm | 8 ++++++++ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/react-native/React/Base/RCTDefines.h b/packages/react-native/React/Base/RCTDefines.h index b9bf3288acf..a36b359b615 100644 --- a/packages/react-native/React/Base/RCTDefines.h +++ b/packages/react-native/React/Base/RCTDefines.h @@ -95,14 +95,6 @@ #define RCT_DEV_MENU RCT_DEV #endif -#ifndef RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION -#if RCT_DEV && (__has_include("RCTPackagerConnection.h") || __has_include()) -#define RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION 1 -#else -#define RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION 0 -#endif -#endif - #if RCT_DEV #define RCT_IF_DEV(...) __VA_ARGS__ #else diff --git a/packages/react-native/React/CoreModules/RCTDevSettings.mm b/packages/react-native/React/CoreModules/RCTDevSettings.mm index 712d890386f..cc4cb1c74e5 100644 --- a/packages/react-native/React/CoreModules/RCTDevSettings.mm +++ b/packages/react-native/React/CoreModules/RCTDevSettings.mm @@ -36,6 +36,14 @@ static NSString *const kRCTDevSettingsUserDefaultsKey = @"RCTDevMenu"; #import #endif +#ifndef RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION +#if RCT_DEV && (__has_include("RCTPackagerConnection.h") || __has_include()) +#define RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION 1 +#else +#define RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION 0 +#endif +#endif + #if RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION #import #endif