From 67bc498b24f6b548eafecd844c849156d91c5f79 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Tue, 20 Sep 2022 19:31:17 -0700 Subject: [PATCH] Bump AGP to 7.3.0 inside the template (#34739) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/34739 AGP 7.3.0 just got released which is glorious! This allows us to remove a lot of unnecessary boilerplate to handle correct task ordering inside the template This requires "react-native-gradle-plugin" version 0.71.1 to be published on NPM. Changelog: [Android] [Changed] - Bump AGP to 7.3.0 inside the template Reviewed By: mdvacca, dmytrorykun Differential Revision: D39653419 fbshipit-source-id: 517363c952cbad2be0f2766c0a2b7daf3e75048b --- template/android/app/build.gradle | 14 -------------- template/android/build.gradle | 2 +- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/template/android/app/build.gradle b/template/android/app/build.gradle index f0ad51910b4..c5eeaacb2b5 100644 --- a/template/android/app/build.gradle +++ b/template/android/app/build.gradle @@ -184,20 +184,6 @@ android { // preBuild.dependsOn("generateCodegenArtifactsFromSchema") preDebugBuild.dependsOn(packageReactNdkDebugLibs) preReleaseBuild.dependsOn(packageReactNdkReleaseLibs) - - // Due to a bug inside AGP, we have to explicitly set a dependency - // between configureCMakeDebug* tasks and the preBuild tasks. - // This can be removed once this is solved: https://issuetracker.google.com/issues/207403732 - configureCMakeRelWithDebInfo.dependsOn(preReleaseBuild) - configureCMakeDebug.dependsOn(preDebugBuild) - reactNativeArchitectures().each { architecture -> - tasks.findByName("configureCMakeDebug[${architecture}]")?.configure { - dependsOn("preDebugBuild") - } - tasks.findByName("configureCMakeRelWithDebInfo[${architecture}]")?.configure { - dependsOn("preReleaseBuild") - } - } } } diff --git a/template/android/build.gradle b/template/android/build.gradle index 8569fee3a7f..30133c1d5b3 100644 --- a/template/android/build.gradle +++ b/template/android/build.gradle @@ -20,7 +20,7 @@ buildscript { mavenCentral() } dependencies { - classpath("com.android.tools.build:gradle:7.2.1") + classpath("com.android.tools.build:gradle:7.3.0") classpath("com.facebook.react:react-native-gradle-plugin") classpath("de.undercouch:gradle-download-task:5.0.1") // NOTE: Do not place your application dependencies here; they belong