From 679a7b7a96b15f46aa87f8e09aff09e8882a8f5f Mon Sep 17 00:00:00 2001 From: generatedunixname89002005232357 Date: Wed, 9 Sep 2026 10:22:39 -0700 Subject: [PATCH] Revert D119065685: fix(babel-preset): preserve Platform.select initializers Differential Revision: D119065685 Original commit changeset: ca209fe9b728 Original Phabricator Diff: D119065685 fbshipit-source-id: 1200093b9a798d795a6d4cf4289839dbe11920ee --- .../__tests__/inline-platform-plugin-test.js | 10 --------- .../src/inline-platform-plugin.js | 22 +++++-------------- 2 files changed, 5 insertions(+), 27 deletions(-) diff --git a/packages/react-native-babel-preset/src/__tests__/inline-platform-plugin-test.js b/packages/react-native-babel-preset/src/__tests__/inline-platform-plugin-test.js index 8c3d53dba1a..2e182e5f763 100644 --- a/packages/react-native-babel-preset/src/__tests__/inline-platform-plugin-test.js +++ b/packages/react-native-babel-preset/src/__tests__/inline-platform-plugin-test.js @@ -483,16 +483,6 @@ describe('Platform.select', () => { expect(select('{ios: 1, ios: 2}')).toContain('const value=2'); }); - test('does not discard impure initializers', () => { - expectUnchanged(` - const value = require('react-native').Platform.select({ - ios: first(), - android: android(), - ios: last(), - }); - `); - }); - test('does not inline computed keys', () => { expect(select('{[key]: 1, default: 2}')).toContain('Platform.select'); }); diff --git a/packages/react-native-babel-preset/src/inline-platform-plugin.js b/packages/react-native-babel-preset/src/inline-platform-plugin.js index 3981c94787d..f70a24b3e95 100644 --- a/packages/react-native-babel-preset/src/inline-platform-plugin.js +++ b/packages/react-native-babel-preset/src/inline-platform-plugin.js @@ -520,25 +520,13 @@ module.exports = function inlinePlatformPlugin( return; } - const replacement = findProperty(spec, platform, () => - findProperty(spec, 'native', () => - findProperty(spec, 'default', () => t.identifier('undefined')), + path.replaceWith( + findProperty(spec, platform, () => + findProperty(spec, 'native', () => + findProperty(spec, 'default', () => t.identifier('undefined')), + ), ), ); - // Inlining must not drop side effects from discarded property values. - // Assess the property itself: an ObjectMethod has no `.value`, so - // checking `property.value` would wrongly treat every method as - // impure and skip inlining. - if ( - spec.properties.every( - property => - (t.isObjectProperty(property) && - property.value === replacement) || - path.scope.isPure(property), - ) - ) { - path.replaceWith(replacement); - } }, }, };