Facebook/react-native
1
0 Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add some more helper methods to Value

Browse Source 
Reviewed By: mhorowitz

Differential Revision: D4197278

fbshipit-source-id: 9a538ff2747d32a54d42627a9f78e4a348dce639
This commit is contained in:
Pieter De Baets authored and Facebook Github Bot committed 2016-11-18 06:28:48 -08:00
1 parent 1604f10889
commit 674d86cdcb
13 files changed
+121 -133
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ReactCommon/cxxreact/JSCNativeModules.cpp
+2 -2
View File
@@ -20,7 +20,7 @@ JSValueRef JSCNativeModules::getModule(JSContextRef context, JSStringRef jsName)
auto module = createModule(moduleName, context);
if (!module.hasValue()) {
return JSValueMakeUndefined(context);
return Value::makeUndefined(context);
}
// Protect since we'll be holding on to this value, even though JS may not
@@ -53,7 +53,7 @@ folly::Optional<Object> JSCNativeModules::createModule(const std::string& name,
Value moduleInfo = m_genNativeModuleJS->callAsFunction({
Value::fromDynamic(context, result->config),
JSValueMakeNumber(context, result->index)
Value::makeNumber(context, result->index)
});
CHECK(!moduleInfo.isNull()) << "Module returned from genNativeModule is null";