Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Migrate ARTGroupShadowNode.java to Android target API 28

Browse Source 
Summary: React Native is using API deprecated in Android API 28. This blocks migrating RN apps to target API 28 which is Google's requirement starting August 2019. Specifically, using the deprecated flags is causing a crash. Here's Google's suggestion for a fix https://developer.android.com/reference/android/graphics/Canvas.html#clipRect(float,%2520float,%2520float,%2520float,%2520android.graphics.Region.Op)

Differential Revision: D16436758

fbshipit-source-id: 92042695f8a1798464b374bff9fa0e5e83e7f461
This commit is contained in:
Stepan Furdei
2019-07-23 14:01:50 -07:00
committed by Facebook Github Bot
parent 0fcaca8e26
commit 6625356b7e
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/views/art/ARTGroupShadowNode.java
+1 -3
View File
@@ -9,7 +9,6 @@ package com.facebook.react.views.art;
import android.graphics.Canvas;
import android.graphics.Paint;
import android.graphics.RectF;
import android.graphics.Region;
import androidx.annotation.Nullable;
import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
import com.facebook.react.bridge.ReadableArray;
@@ -46,8 +45,7 @@ public class ARTGroupShadowNode extends ARTVirtualNode {
mClipping.left * mScale,
mClipping.top * mScale,
mClipping.right * mScale,
mClipping.bottom * mScale,
Region.Op.REPLACE);
mClipping.bottom * mScale);
}
for (int i = 0; i < getChildCount(); i++) {