mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Refactor RootTag -> surfaceId
Summary: Quick diff to refactor RootTag for surfaceId in Binding.cpp class This is the first diff to start moving away from rootTag naming in Fabric Reviewed By: JoshuaGross Differential Revision: D15421770 fbshipit-source-id: 7bca7782f96be3d7148ee93f5d5a3a54e0d768dd
This commit is contained in:
committed by
Facebook Github Bot
parent
3c464782e0
commit
651ca3bc9f
@@ -49,7 +49,7 @@ public class Binding {
|
||||
public native void setPixelDensity(float pointScaleFactor);
|
||||
|
||||
public native void setConstraints(
|
||||
int rootTag, float minWidth, float maxWidth, float minHeight, float maxHeight);
|
||||
int surfaceId, float minWidth, float maxWidth, float minHeight, float maxHeight);
|
||||
|
||||
public void register(
|
||||
JavaScriptContextHolder jsContext,
|
||||
|
||||
@@ -67,7 +67,7 @@ void Binding::stopSurface(jint surfaceId) {
|
||||
}
|
||||
|
||||
void Binding::setConstraints(
|
||||
jint rootTag,
|
||||
jint surfaceId,
|
||||
jfloat minWidth,
|
||||
jfloat maxWidth,
|
||||
jfloat minHeight,
|
||||
@@ -84,7 +84,7 @@ void Binding::setConstraints(
|
||||
constraints.minimumSize = minimumSize;
|
||||
constraints.maximumSize = maximumSize;
|
||||
|
||||
scheduler_->constraintSurfaceLayout(rootTag, constraints, context);
|
||||
scheduler_->constraintSurfaceLayout(surfaceId, constraints, context);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -329,7 +329,7 @@ local_ref<JMountItem::javaobject> createDeleteMountItem(
|
||||
local_ref<JMountItem::javaobject> createCreateMountItem(
|
||||
const jni::global_ref<jobject>& javaUIManager,
|
||||
const ShadowViewMutation& mutation,
|
||||
const Tag rootTag) {
|
||||
const Tag surfaceId) {
|
||||
static auto createJavaInstruction =
|
||||
jni::findClassStatic(UIManagerJavaDescriptor)
|
||||
->getMethod<alias_ref<JMountItem>(jstring, jint, jint, jboolean)>(
|
||||
@@ -345,7 +345,7 @@ local_ref<JMountItem::javaobject> createCreateMountItem(
|
||||
return createJavaInstruction(
|
||||
javaUIManager,
|
||||
componentName.get(),
|
||||
rootTag,
|
||||
surfaceId,
|
||||
newChildShadowView.tag,
|
||||
isLayoutable);
|
||||
}
|
||||
|
||||
@@ -34,7 +34,7 @@ class Binding : public jni::HybridClass<Binding>, public SchedulerDelegate {
|
||||
|
||||
private:
|
||||
void setConstraints(
|
||||
jint rootTag,
|
||||
jint surfaceId,
|
||||
jfloat minWidth,
|
||||
jfloat maxWidth,
|
||||
jfloat minHeight,
|
||||
|
||||
Reference in New Issue
Block a user