Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove @Nullable annotation from ArrayList element types

Browse Source 
Summary: Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D26051159

fbshipit-source-id: 54315dc505a4fb4e595847902caf501b4ecd77e2
This commit is contained in:
Ramanpreet Nara
2021-01-26 17:07:00 -08:00
committed by Facebook GitHub Bot
parent 8461409e88
commit 6506f7a680
2 changed files with 24 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native-codegen/src/generators/components/GeneratePropsJavaPojo/serializePojo.js
Vendored
+6 -12
View File
@@ -122,8 +122,7 @@ function toJavaType(
return 'Boolean';
}
case 'StringTypeAnnotation': {
importNullable();
return '@Nullable String';
return 'String';
}
case 'DoubleTypeAnnotation': {
return 'Double';
@@ -140,8 +139,7 @@ function toJavaType(
*/
// TODO: Make StringEnums type-safe in Pojos
case 'StringEnumTypeAnnotation': {
importNullable();
return '@Nullable String';
return 'String';
}
/**
@@ -157,26 +155,22 @@ function toJavaType(
case 'ReservedPropTypeAnnotation': {
switch (elementType.name) {
case 'ColorPrimitive':
importNullable();
return '@Nullable Integer';
return 'Integer';
// TODO: Make ImageSourcePrimitive type-safe
case 'ImageSourcePrimitive':
importNullable();
importReadableMap();
return '@Nullable ReadableMap';
return 'ReadableMap';
// TODO: Make PointPrimitive type-safe
case 'PointPrimitive':
importNullable();
importReadableMap();
return '@Nullable ReadableMap';
return 'ReadableMap';
// TODO: Make EdgeInsetsPrimitive type-safe
case 'EdgeInsetsPrimitive':
importNullable();
importReadableMap();
return '@Nullable ReadableMap';
return 'ReadableMap';
default:
(elementType.name: empty);
throw new Error(