From 64e789e1e51f3745ced70b77c40b9cec598bee64 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Tue, 18 Apr 2023 08:31:17 -0700 Subject: [PATCH] Mark dtor as virtual (#36932) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36932 changelog: [internal] ShadowNode must have its destructor as virtual because it is a base class and is used polymorphically. It is deleted through a pointer. Reviewed By: nlutsenko Differential Revision: D45045682 fbshipit-source-id: 882d06d2ab200c201acc09693cb982561e908859 --- .../react-native/ReactCommon/react/renderer/core/ShadowNode.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h index b38da76fb5a..fac0f4ecb78 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h +++ b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h @@ -91,6 +91,8 @@ class ShadowNode : public Sealable, ShadowNode(ShadowNode const &shadowNode) noexcept = delete; ShadowNode &operator=(ShadowNode const &other) noexcept = delete; + virtual ~ShadowNode() override = default; + /* * Clones the shadow node using stored `cloneFunction`. */