From 648aaf440b70780e3ca35314760cd6c5e69ea8a0 Mon Sep 17 00:00:00 2001 From: Mart?n Bigio Date: Fri, 8 Apr 2016 07:33:14 -0700 Subject: [PATCH] Avoid crashing when executor is invalidated before it finishes loading RA Bundle Reviewed By: alexeylang Differential Revision: D3150719 fb-gh-sync-id: 46e516757e110e985980056f2a8b6eaa22e522b0 fbshipit-source-id: 46e516757e110e985980056f2a8b6eaa22e522b0 --- React/Executors/RCTJSCExecutor.m | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/React/Executors/RCTJSCExecutor.m b/React/Executors/RCTJSCExecutor.m index 940222c1b51..6cbc44cd883 100644 --- a/React/Executors/RCTJSCExecutor.m +++ b/React/Executors/RCTJSCExecutor.m @@ -380,11 +380,6 @@ static void RCTInstallJSCProfiler(RCTBridge *bridge, JSContextRef context) _valid = NO; - if (_jsModules) { - CFRelease(_jsModules); - fclose(_bundle); - } - #if RCT_DEV [[NSNotificationCenter defaultCenter] removeObserver:self]; #endif @@ -399,6 +394,11 @@ static void RCTInstallJSCProfiler(RCTBridge *bridge, JSContextRef context) withObject:nil waitUntilDone:NO]; _context = nil; + + if (_jsModules) { + CFRelease(_jsModules); + fclose(_bundle); + } } - (void)flushedQueue:(RCTJavaScriptCallback)onComplete