Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor names of ReadableMapBuffer class variables

Browse Source 
Summary:
Refactor names of ReadableMapBuffer class variables

changelog: [internal] internal

Reviewed By: sammy-SC

Differential Revision: D27867056

fbshipit-source-id: de96429cbd1142e14fa74f7f953d560ba5918954
This commit is contained in:
David Vacca
2021-04-21 10:22:31 -07:00
committed by Facebook GitHub Bot
parent 42dceaf21c
commit 64844d900a
2 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/common/mapbuffer/jni/react/common/mapbuffer/ReadableMapBuffer.cpp
+8 -6
View File
@@ -26,9 +26,9 @@ ReadableMapBuffer::importByteBufferAllocateDirect() {
// steps:
// - Validate perf of this method vs importByteBuffer
// - Validate that there's no leaking of memory
auto ret = jni::JByteBuffer::allocateDirect(_serializedDataSize);
auto ret = jni::JByteBuffer::allocateDirect(serializedDataSize_);
std::memcpy(
ret->getDirectBytes(), (void *)_serializedData, _serializedDataSize);
ret->getDirectBytes(), (void *)serializedData_, serializedDataSize_);
return ret;
}
@@ -47,7 +47,7 @@ jni::JByteBuffer::javaobject ReadableMapBuffer::importByteBuffer() {
// transfer data of multitple Maps
return static_cast<jni::JByteBuffer::javaobject>(
jni::Environment::current()->NewDirectByteBuffer(
(void *)_serializedData, _serializedDataSize));
(void *)serializedData_, serializedDataSize_));
}
jni::local_ref<ReadableMapBuffer::jhybridobject>
@@ -56,9 +56,11 @@ ReadableMapBuffer::createWithContents(MapBuffer &&map) {
}
ReadableMapBuffer::~ReadableMapBuffer() {
delete[] _serializedData;
_serializedData = nullptr;
_serializedDataSize = 0;
if (serializedData_ != nullptr) {
delete[] serializedData_;
serializedData_ = nullptr;
}
serializedDataSize_ = 0;
}
} // namespace react
ReactAndroid/src/main/java/com/facebook/react/common/mapbuffer/jni/react/common/mapbuffer/ReadableMapBuffer.h
+6 -6
View File
@@ -32,18 +32,18 @@ class ReadableMapBuffer : public jni::HybridClass<ReadableMapBuffer> {
~ReadableMapBuffer();
private:
uint8_t *_serializedData = nullptr;
uint8_t *serializedData_ = nullptr;
int _serializedDataSize = 0;
int serializedDataSize_ = 0;
friend HybridBase;
explicit ReadableMapBuffer(MapBuffer &&map) {
_serializedDataSize = map.getBufferSize();
serializedDataSize_ = map.getBufferSize();
react_native_assert(
(_serializedDataSize != 0) && "Error no content in map");
_serializedData = new Byte[_serializedDataSize];
map.copy(_serializedData);
(serializedDataSize_ != 0) && "Error no content in map");
serializedData_ = new Byte[serializedDataSize_];
map.copy(serializedData_);
}
};