From 646ff6e70e4658a5d8d2ac34a9da334acc2f82c3 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Tue, 12 Dec 2023 10:55:32 -0800 Subject: [PATCH] Remove REACT_NATIVE_SKIP_PREFAB as unused (#41833) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/41833 I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227 fbshipit-source-id: 6579ff73d3030fe1acb587250cd99aff44a1de29 --- packages/react-native/ReactAndroid/build.gradle.kts | 5 +---- .../react-native/ReactAndroid/hermes-engine/build.gradle | 6 +----- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/packages/react-native/ReactAndroid/build.gradle.kts b/packages/react-native/ReactAndroid/build.gradle.kts index bb035d25c75..e41507c1c79 100644 --- a/packages/react-native/ReactAndroid/build.gradle.kts +++ b/packages/react-native/ReactAndroid/build.gradle.kts @@ -60,9 +60,6 @@ val dependenciesPath = System.getenv("REACT_NATIVE_DEPENDENCIES") // and the build will use that. val boostPathOverride = dependenciesPath ?: System.getenv("REACT_NATIVE_BOOST_PATH") -// By setting REACT_NATIVE_SKIP_PREFAB we can skip prefab publishing, to -// reduce the size of the React Native published .AAR. -val skipPrefabPublishing = System.getenv("REACT_NATIVE_SKIP_PREFAB") != null val prefabHeadersDir = project.file("$buildDir/prefab-headers") // Native versions which are defined inside the version catalog (libs.versions.toml) @@ -635,7 +632,7 @@ android { buildFeatures { prefab = true - prefabPublishing = !skipPrefabPublishing + prefabPublishing = true buildConfig = true } diff --git a/packages/react-native/ReactAndroid/hermes-engine/build.gradle b/packages/react-native/ReactAndroid/hermes-engine/build.gradle index 25916bf2963..f008a5dd8ab 100644 --- a/packages/react-native/ReactAndroid/hermes-engine/build.gradle +++ b/packages/react-native/ReactAndroid/hermes-engine/build.gradle @@ -63,10 +63,6 @@ if (hermesVersionFile.exists()) { def ndkBuildJobs = Runtime.runtime.availableProcessors().toString() def prefabHeadersDir = new File("$buildDir/prefab-headers") -// By setting REACT_NATIVE_HERMES_SKIP_PREFAB you can skip prefab publishing, to -// reduce the size of the Hermes published .AAR. -def skipPrefabPublishing = System.getenv("REACT_NATIVE_HERMES_SKIP_PREFAB") != null - // We inject the JSI directory used inside the Hermes build with the -DJSI_DIR config. def jsiDir = new File(reactNativeRootDir, "ReactCommon/jsi") @@ -245,7 +241,7 @@ android { buildFeatures { prefab true - prefabPublishing !skipPrefabPublishing + prefabPublishing true } dependencies {