mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
feat: Add tabIndex prop to View component (#34486)
Summary: This adds the `tabIndex` Android only prop to View as requested on https://github.com/facebook/react-native/issues/34424 mapping the existing `focusable` prop to `tabIndex` so that `tabIndex={0}` maps to `focusable={true}` and `tabIndex={-1}` represents ` focusable={false}`. ## Changelog [Android] [Added] - Add tabIndex prop to View component Pull Request resolved: https://github.com/facebook/react-native/pull/34486 Test Plan: I'm still investigating the best way to test this but we're are just mapping this to an existing prop Reviewed By: GijsWeterings Differential Revision: D38957303 Pulled By: necolas fbshipit-source-id: d00db854e11cb3457329c1547b69cff60afb34cf
This commit is contained in:
1 parent
4d642a2250
commit
621f4cf3b1
2 files changed
+26
-7
No files matched your search
@@ -26,13 +26,19 @@ export type Props = ViewProps;
|
||||
const View: React.AbstractComponent<
|
||||
ViewProps,
|
||||
React.ElementRef<typeof ViewNativeComponent>,
|
||||
> = React.forwardRef((props: ViewProps, forwardedRef) => {
|
||||
return (
|
||||
<TextAncestor.Provider value={false}>
|
||||
<ViewNativeComponent {...props} ref={forwardedRef} />
|
||||
</TextAncestor.Provider>
|
||||
);
|
||||
});
|
||||
> = React.forwardRef(
|
||||
({tabIndex, focusable, ...otherProps}: ViewProps, forwardedRef) => {
|
||||
return (
|
||||
<TextAncestor.Provider value={false}>
|
||||
<ViewNativeComponent
|
||||
focusable={tabIndex !== undefined ? !tabIndex : focusable}
|
||||
{...otherProps}
|
||||
ref={forwardedRef}
|
||||
/>
|
||||
</TextAncestor.Provider>
|
||||
);
|
||||
},
|
||||
);
|
||||
|
||||
View.displayName = 'View';
|
||||
|
||||
|
||||
@@ -352,6 +352,19 @@ type AndroidViewProps = $ReadOnly<{|
|
||||
*/
|
||||
focusable?: boolean,
|
||||
|
||||
/**
|
||||
* Indicates whether this `View` should be focusable with a non-touch input device, eg. receive focus with a hardware keyboard.
|
||||
* See https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex
|
||||
* for more details.
|
||||
*
|
||||
* Supports the following values:
|
||||
* - 0 (View is focusable)
|
||||
* - -1 (View is not focusable)
|
||||
*
|
||||
* @platform android
|
||||
*/
|
||||
tabIndex?: 0 | -1,
|
||||
|
||||
/**
|
||||
* The action to perform when this `View` is clicked on by a non-touch click, eg. enter key on a hardware keyboard.
|
||||
*
|
||||
|
||||
Reference in new issue
Block a user