Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Force WithDefault not to be an optional value

Browse Source 
Summary:
`WithDefault` appears not to be required to be prefixed with `?` because it's option value per se.

Fixed tests, removed `?` where needed, updated snapshots and review them. Added mechanism fro throwing error when `?WithDefault` found. Add tests for it.

Reviewed By: rubennorte

Differential Revision: D16048463

fbshipit-source-id: f55ed7454aacf0b8c42944a9b5c1037ad1b360fe
This commit is contained in:
Michał Osadnik
2019-07-02 03:30:55 -07:00
committed by Facebook Github Bot
parent b476ad78b5
commit 61e95e5cbf
19 changed files with 110 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Components/SegmentedControlIOS/RCTSegmentedControlNativeComponent.js
+3 -3
View File
@@ -28,10 +28,10 @@ type NativeProps = $ReadOnly<{|
// Props
values?: $ReadOnlyArray<string>,
selectedIndex?: ?WithDefault<Int32, 0>,
enabled?: ?WithDefault<boolean, true>,
selectedIndex?: WithDefault<Int32, 0>,
enabled?: WithDefault<boolean, true>,
tintColor?: ?ColorValue,
momentary?: ?WithDefault<boolean, false>,
momentary?: WithDefault<boolean, false>,
// Events
onChange?: ?BubblingEventHandler<OnChangeEvent>,