Force WithDefault not to be an optional value

Summary:
`WithDefault` appears not to be required to be prefixed with `?` because it's option value per se.

Fixed tests, removed `?` where needed, updated snapshots and review them. Added mechanism fro throwing error when `?WithDefault` found. Add tests for it.

Reviewed By: rubennorte

Differential Revision: D16048463

fbshipit-source-id: f55ed7454aacf0b8c42944a9b5c1037ad1b360fe
This commit is contained in:
Michał Osadnik authored and Facebook Github Bot committed 2019-07-02 03:30:55 -07:00
1 parent b476ad78b5
commit 61e95e5cbf
19 files changed
+110 -101

No files matched your search

@@ -21,8 +21,8 @@ type NativeProps = $ReadOnly<{|
...ViewProps,
// Props
progressViewStyle?: ?WithDefault<'default' | 'bar', 'default'>,
progress?: ?WithDefault<Float, 0>,
progressViewStyle?: WithDefault<'default' | 'bar', 'default'>,
progress?: WithDefault<Float, 0>,
progressTintColor?: ?ColorValue,
trackTintColor?: ?ColorValue,
progressImage?: ?ImageSource,