Force WithDefault not to be an optional value

Summary:
`WithDefault` appears not to be required to be prefixed with `?` because it's option value per se.

Fixed tests, removed `?` where needed, updated snapshots and review them. Added mechanism fro throwing error when `?WithDefault` found. Add tests for it.

Reviewed By: rubennorte

Differential Revision: D16048463

fbshipit-source-id: f55ed7454aacf0b8c42944a9b5c1037ad1b360fe
This commit is contained in:
Michał Osadnik
2019-07-02 03:30:55 -07:00
committed by Facebook Github Bot
parent b476ad78b5
commit 61e95e5cbf
19 changed files with 110 additions and 101 deletions
@@ -24,9 +24,9 @@ type NativeProps = $ReadOnly<{|
typeAttr?: string,
indeterminate: boolean,
progress?: WithDefault<Float, 0>,
animating?: ?WithDefault<boolean, true>,
animating?: WithDefault<boolean, true>,
color?: ?ColorValue,
testID?: ?WithDefault<string, ''>,
testID?: WithDefault<string, ''>,
|}>;
export default codegenNativeComponent<NativeProps>('AndroidProgressBar');