From 61a16fe1b6a3d61a8882902f06431028a506ab2b Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 7 Aug 2020 19:45:52 -0700 Subject: [PATCH] Refactor Runnable C++ class to compile in OSS Summary: This diff refactors the class Runnable into a struct to make it work in OSS changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D22963704 fbshipit-source-id: 2212c8f1e4a62b2bcad5c061709e29b247454fc1 --- .../java/com/facebook/react/fabric/jni/JBackgroundExecutor.cpp | 2 +- ReactAndroid/src/main/jni/react/jni/JNativeRunnable.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/JBackgroundExecutor.cpp b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/JBackgroundExecutor.cpp index 39cb4a4e593..63ab0918bca 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/JBackgroundExecutor.cpp +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/JBackgroundExecutor.cpp @@ -27,7 +27,7 @@ BackgroundExecutor JBackgroundExecutor::get() { ->getMethod("queueRunnable"); auto jrunnable = JNativeRunnable::newObjectCxxArgs(std::move(runnable)); - method(self, static_ref_cast(jrunnable).get()); + method(self, static_ref_cast(jrunnable).get()); }; } diff --git a/ReactAndroid/src/main/jni/react/jni/JNativeRunnable.h b/ReactAndroid/src/main/jni/react/jni/JNativeRunnable.h index b45d84c90a6..28c547384a8 100644 --- a/ReactAndroid/src/main/jni/react/jni/JNativeRunnable.h +++ b/ReactAndroid/src/main/jni/react/jni/JNativeRunnable.h @@ -16,7 +16,7 @@ using namespace facebook::jni; namespace facebook { namespace react { -class Runnable : public JavaClass { +struct Runnable : public JavaClass { public: static constexpr auto kJavaDescriptor = "Ljava/lang/Runnable;"; };