From 60c0a60c508346f7639d32fde0376fabded9f3f0 Mon Sep 17 00:00:00 2001 From: Vishwesh Jainkuniya Date: Wed, 27 Feb 2019 22:15:33 -0800 Subject: [PATCH] Fix: mostRecentEventCount is not updated. (#17990) Summary: Update it's value as it changes on the JS thread, so that updated value is used (https://github.com/facebook/react-native/blob/f7f5dc66493ad25a85927a9503728b0491c8aab9/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java#L243) whenever setSelection(int start, int end) is called (https://github.com/facebook/react-native/blob/f7f5dc66493ad25a85927a9503728b0491c8aab9/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java#L315). Pull Request resolved: https://github.com/facebook/react-native/pull/17990 Differential Revision: D14255969 Pulled By: mdvacca fbshipit-source-id: 555d6752eabca5c31c1762955a56f99cc1828546 --- .../com/facebook/react/views/textinput/ReactEditText.java | 4 ++++ .../react/views/textinput/ReactTextInputManager.java | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java index 0b59a3c9e94..8bd0081e219 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java @@ -236,6 +236,10 @@ public class ReactEditText extends EditText { mContentSizeWatcher = contentSizeWatcher; } + public void setMostRecentEventCount(int mostRecentEventCount) { + mMostRecentEventCount = mostRecentEventCount; + } + public void setScrollWatcher(ScrollWatcher scrollWatcher) { mScrollWatcher = scrollWatcher; } diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java index 9cb5990ed15..06e80a189a2 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java @@ -408,6 +408,11 @@ public class ReactTextInputManager extends BaseViewManager