From 5fd25e3ebb00a9e95e3da5f26d753b8184df7125 Mon Sep 17 00:00:00 2001
From: Riccardo Cipolleschi <cipolleschi@meta.com>
Date: Wed, 4 Jun 2025 04:28:10 -0700
Subject: [PATCH] Bump windows to latests as GH will remove windows-2019 EOM
 (#51798)

Summary:
As per title, GH is [removing windows-2019](https://github.com/facebook/react-native/actions/runs/15421451006/job/43403215354) at the end of the month. We need to migrate away from them.

## Changelog:
[Internal] - Bump windows runners

Pull Request resolved: https://github.com/facebook/react-native/pull/51798

Test Plan: GHA

Reviewed By: cortinico

Differential Revision: D75946994

Pulled By: cipolleschi

fbshipit-source-id: 972b60300c918c0eae0403ed4149347a4ffa8bd0
---
 .github/actions/build-hermesc-windows/action.yml | 4 ++--
 .github/workflows/nightly.yml                    | 2 +-
 .github/workflows/publish-release.yml            | 2 +-
 .github/workflows/test-all.yml                   | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/actions/build-hermesc-windows/action.yml b/.github/actions/build-hermesc-windows/action.yml
index aec9927e36e..1491b381201 100644
--- a/.github/actions/build-hermesc-windows/action.yml
+++ b/.github/actions/build-hermesc-windows/action.yml
@@ -25,7 +25,7 @@ runs:
     - name: Windows cache
       uses: actions/cache@v4
       with:
-        key: v2-hermes-${{ github.job }}-windows-${{ inputs.hermes-version }}-${{ inputs.react-native-version }}
+        key: v3-hermes-${{ github.job }}-windows-${{ inputs.hermes-version }}-${{ inputs.react-native-version }}
         path: |
           D:\tmp\hermes\win64-bin\
           D:\tmp\hermes\hermes\icu\
@@ -60,7 +60,7 @@ runs:
           $Env:PATH += ";$Env:CMAKE_DIR;$Env:MSBUILD_DIR"
           $Env:ICU_ROOT = "$Env:HERMES_WS_DIR\icu"
 
-          cmake -S hermes -B build_release -G 'Visual Studio 16 2019' -Ax64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=True -DHERMES_ENABLE_WIN10_ICU_FALLBACK=OFF
+          cmake -S hermes -B build_release -G 'Visual Studio 17 2022' -Ax64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=True -DHERMES_ENABLE_WIN10_ICU_FALLBACK=OFF
           if (-not $?) { throw "Failed to configure Hermes" }
           echo "Running windows build..."
           cd build_release
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
index 00631c22afd..6957be9065b 100644
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -116,7 +116,7 @@ jobs:
           react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
 
   build_hermesc_windows:
-    runs-on: windows-2019
+    runs-on: windows-2025
     needs: prepare_hermes_workspace
     env:
       HERMES_WS_DIR: 'D:\tmp\hermes'
diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml
index d57bbc72dea..9af5c76aabf 100644
--- a/.github/workflows/publish-release.yml
+++ b/.github/workflows/publish-release.yml
@@ -113,7 +113,7 @@ jobs:
           react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
 
   build_hermesc_windows:
-    runs-on: windows-2019
+    runs-on: windows-2025
     needs: prepare_hermes_workspace
     env:
       HERMES_WS_DIR: 'D:\tmp\hermes'
diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml
index b10d34c2323..917d7bde116 100644
--- a/.github/workflows/test-all.yml
+++ b/.github/workflows/test-all.yml
@@ -397,7 +397,7 @@ jobs:
           react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
 
   build_hermesc_windows:
-    runs-on: windows-2019
+    runs-on: windows-2025
     needs: prepare_hermes_workspace
     env:
       HERMES_WS_DIR: 'D:\tmp\hermes'