ArrayBuffer support to Java TurboModules

Summary:
Changelog:
[ANDROID] [ADDED] - Add ArrayBuffer support to Java TurboModules

- Codegen: ArrayBufferTypeAnnotation → ByteBuffer / ArrayBufferKind / Ljava/nio/ByteBuffer; in GenerateModuleJavaSpec and GenerateModuleJniCpp. Guard in Utils.js rejects Promise<ArrayBuffer> on Android at codegen time — drops async return to avoid CxxCallbackImpl.kt / JCallback / PromiseImpl.kt changes.

- Runtime: New JByteBufferMutableBuffer.h — jsi::MutableBuffer wrapping global_ref<JByteBuffer> direct ByteBuffer, holds Java object alive for JS ArrayBuffer lifetime; dtor uses ThreadScope to attach JNI thread (Hermes GC finalizes off-thread). Zero-copy native→JS return mirrors iOS NSMutableDataBuffer. Args JS→Java always copied into Java-owned direct ByteBuffer via allocateDirect+memcpy (mirrors iOS NSData copy), no sync/async branching — safe to retain/dispatch past GC.

- No changes to CxxCallbackImpl.kt, JCallback, PromiseImpl.kt. Nested ArrayBuffers still via folly::dynamic, deferred like ObjC/C++.

- Samples: NativeSampleTurboModule.js spec, SampleTurboModule.kt (getArrayBuffer/ createNativeBuffer/ processAsyncBuffer), RCTSampleTurboModule.mm. (NSData param / NSMutableData return), RNTester UI SampleTurboModuleExample.js.

X-link: https://github.com/facebook/react-native/pull/57062

Reviewed By: javache

Differential Revision: D107411163

Pulled By: christophpurrer

fbshipit-source-id: 67cc5da796a87f6918f0382debc5c5594f76661b
This commit is contained in:
Kamil Paradowski authored and meta-codesync[bot] committed 2026-08-06 12:28:37 -07:00
1 parent 3f3425e246
commit 5fb3ebce1a
26 files changed
+707 -28

No files matched your search

@@ -2796,6 +2796,17 @@ class facebook::react::JBindingsInstaller : public jni::HybridClass<facebook::re
public ~JBindingsInstaller();
}
class facebook::react::JByteBufferMutableBuffer : public facebook::jsi::MutableBuffer {
public JByteBufferMutableBuffer(const facebook::react::JByteBufferMutableBuffer&) = delete;
public JByteBufferMutableBuffer(facebook::react::JByteBufferMutableBuffer&&) = delete;
public JByteBufferMutableBuffer(jni::alias_ref<jni::JByteBuffer> byteBuffer);
public facebook::react::JByteBufferMutableBuffer& operator=(const facebook::react::JByteBufferMutableBuffer&) = delete;
public facebook::react::JByteBufferMutableBuffer& operator=(facebook::react::JByteBufferMutableBuffer&&) = delete;
public virtual size_t size() const override;
public virtual uint8_t* data() override;
public ~JByteBufferMutableBuffer() override;
}
class facebook::react::JCxxCallbackImpl : public jni::HybridClass<facebook::react::JCxxCallbackImpl, facebook::react::JCallback> {
public static constexpr auto kJavaDescriptor;
public static void registerNatives();
@@ -2754,6 +2754,17 @@ class facebook::react::JBindingsInstaller : public jni::HybridClass<facebook::re
public ~JBindingsInstaller();
}
class facebook::react::JByteBufferMutableBuffer : public facebook::jsi::MutableBuffer {
public JByteBufferMutableBuffer(const facebook::react::JByteBufferMutableBuffer&) = delete;
public JByteBufferMutableBuffer(facebook::react::JByteBufferMutableBuffer&&) = delete;
public JByteBufferMutableBuffer(jni::alias_ref<jni::JByteBuffer> byteBuffer);
public facebook::react::JByteBufferMutableBuffer& operator=(const facebook::react::JByteBufferMutableBuffer&) = delete;
public facebook::react::JByteBufferMutableBuffer& operator=(facebook::react::JByteBufferMutableBuffer&&) = delete;
public virtual size_t size() const override;
public virtual uint8_t* data() override;
public ~JByteBufferMutableBuffer() override;
}
class facebook::react::JCxxCallbackImpl : public jni::HybridClass<facebook::react::JCxxCallbackImpl, facebook::react::JCallback> {
public static constexpr auto kJavaDescriptor;
public static void registerNatives();
@@ -2793,6 +2793,17 @@ class facebook::react::JBindingsInstaller : public jni::HybridClass<facebook::re
public ~JBindingsInstaller();
}
class facebook::react::JByteBufferMutableBuffer : public facebook::jsi::MutableBuffer {
public JByteBufferMutableBuffer(const facebook::react::JByteBufferMutableBuffer&) = delete;
public JByteBufferMutableBuffer(facebook::react::JByteBufferMutableBuffer&&) = delete;
public JByteBufferMutableBuffer(jni::alias_ref<jni::JByteBuffer> byteBuffer);
public facebook::react::JByteBufferMutableBuffer& operator=(const facebook::react::JByteBufferMutableBuffer&) = delete;
public facebook::react::JByteBufferMutableBuffer& operator=(facebook::react::JByteBufferMutableBuffer&&) = delete;
public virtual size_t size() const override;
public virtual uint8_t* data() override;
public ~JByteBufferMutableBuffer() override;
}
class facebook::react::JCxxCallbackImpl : public jni::HybridClass<facebook::react::JCxxCallbackImpl, facebook::react::JCallback> {
public static constexpr auto kJavaDescriptor;
public static void registerNatives();
@@ -2500,6 +2500,8 @@ protocol NativeSampleTurboModuleSpec : public NSObjectRCTBridgeModule, public RC
public virtual NSDictionary* getObjectThrows:(NSDictionary* arg);
public virtual NSDictionary* getUnsafeObject:(NSDictionary* arg);
public virtual NSDictionary* getValue:y:z:(double x, NSString* y, NSDictionary* z);
public virtual NSMutableData* createNativeBuffer:(double size);
public virtual NSMutableData* getArrayBuffer:(NSData* buffer);
public virtual NSNumber* getBool:(BOOL arg);
public virtual NSNumber* getEnum:(double arg);
public virtual NSNumber* getNumber:(double arg);
@@ -2510,6 +2512,7 @@ protocol NativeSampleTurboModuleSpec : public NSObjectRCTBridgeModule, public RC
public virtual void getImageUrl:reject:(RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void getValueWithCallback:(RCTResponseSenderBlock callback);
public virtual void getValueWithPromise:resolve:reject:(BOOL error, RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void processAsyncBuffer:resolve:reject:(NSData* payload, RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void promiseAssert:reject:(RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void promiseThrows:reject:(RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void voidFunc();
@@ -2489,6 +2489,8 @@ protocol NativeSampleTurboModuleSpec : public NSObjectRCTBridgeModule, public RC
public virtual NSDictionary* getObjectThrows:(NSDictionary* arg);
public virtual NSDictionary* getUnsafeObject:(NSDictionary* arg);
public virtual NSDictionary* getValue:y:z:(double x, NSString* y, NSDictionary* z);
public virtual NSMutableData* createNativeBuffer:(double size);
public virtual NSMutableData* getArrayBuffer:(NSData* buffer);
public virtual NSNumber* getBool:(BOOL arg);
public virtual NSNumber* getEnum:(double arg);
public virtual NSNumber* getNumber:(double arg);
@@ -2499,6 +2501,7 @@ protocol NativeSampleTurboModuleSpec : public NSObjectRCTBridgeModule, public RC
public virtual void getImageUrl:reject:(RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void getValueWithCallback:(RCTResponseSenderBlock callback);
public virtual void getValueWithPromise:resolve:reject:(BOOL error, RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void processAsyncBuffer:resolve:reject:(NSData* payload, RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void promiseAssert:reject:(RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void promiseThrows:reject:(RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void voidFunc();
@@ -2500,6 +2500,8 @@ protocol NativeSampleTurboModuleSpec : public NSObjectRCTBridgeModule, public RC
public virtual NSDictionary* getObjectThrows:(NSDictionary* arg);
public virtual NSDictionary* getUnsafeObject:(NSDictionary* arg);
public virtual NSDictionary* getValue:y:z:(double x, NSString* y, NSDictionary* z);
public virtual NSMutableData* createNativeBuffer:(double size);
public virtual NSMutableData* getArrayBuffer:(NSData* buffer);
public virtual NSNumber* getBool:(BOOL arg);
public virtual NSNumber* getEnum:(double arg);
public virtual NSNumber* getNumber:(double arg);
@@ -2510,6 +2512,7 @@ protocol NativeSampleTurboModuleSpec : public NSObjectRCTBridgeModule, public RC
public virtual void getImageUrl:reject:(RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void getValueWithCallback:(RCTResponseSenderBlock callback);
public virtual void getValueWithPromise:resolve:reject:(BOOL error, RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void processAsyncBuffer:resolve:reject:(NSData* payload, RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void promiseAssert:reject:(RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void promiseThrows:reject:(RCTPromiseResolveBlock resolve, RCTPromiseRejectBlock reject);
public virtual void voidFunc();