From 5f98d404b46aa1d92bc2c3efdd915f265bd26887 Mon Sep 17 00:00:00 2001
From: Nicola Corti <ncor@meta.com>
Date: Mon, 21 Jul 2025 15:43:23 +0100
Subject: [PATCH] Do not setup-node twice

---
 .github/actions/build-hermes-macos/action.yml       | 4 ++--
 .github/actions/build-npm-package/action.yml        | 4 ++--
 .github/actions/create-release/action.yml           | 2 ++
 .github/actions/maestro-ios/action.yml              | 2 ++
 .github/actions/prepare-hermes-workspace/action.yml | 5 ++---
 .github/actions/test-ios-helloworld/action.yml      | 4 ++--
 .github/actions/yarn-install/action.yml             | 2 --
 7 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/.github/actions/build-hermes-macos/action.yml b/.github/actions/build-hermes-macos/action.yml
index 41c7e6e869c..d2c3eeed4e3 100644
--- a/.github/actions/build-hermes-macos/action.yml
+++ b/.github/actions/build-hermes-macos/action.yml
@@ -15,8 +15,6 @@ runs:
   steps:
     - name: Setup xcode
       uses: ./.github/actions/setup-xcode
-    - name: Setup node.js
-      uses: ./.github/actions/setup-node
     - name: Restore Hermes workspace
       uses: ./.github/actions/restore-hermes-workspace
     - name: Restore Cached Artifacts
@@ -45,6 +43,8 @@ runs:
           echo "ARTIFACTS_EXIST=true" >> $GITHUB_ENV
           echo "ARTIFACTS_EXIST=true" >> $GITHUB_OUTPUT
         fi
+    - name: Setup node.js
+      uses: ./.github/actions/setup-node
     - name: Yarn- Install Dependencies
       if: ${{ steps.check_if_apple_artifacts_are_there.outputs.ARTIFACTS_EXIST != 'true' }}
       uses: ./.github/actions/yarn-install
diff --git a/.github/actions/build-npm-package/action.yml b/.github/actions/build-npm-package/action.yml
index 807e03a742c..4e4e0d6d6c6 100644
--- a/.github/actions/build-npm-package/action.yml
+++ b/.github/actions/build-npm-package/action.yml
@@ -116,12 +116,12 @@ runs:
     - name: Print Artifacts Directory
       shell: bash
       run: ls -lR ./packages/react-native/ReactAndroid/external-artifacts/artifacts/
-    - name: Setup node.js
-      uses: ./.github/actions/setup-node
     - name: Setup gradle
       uses: ./.github/actions/setup-gradle
       with:
         cache-encryption-key: ${{ inputs.gradle-cache-encryption-key }}
+    - name: Setup node.js
+      uses: ./.github/actions/setup-node
     - name: Install dependencies
       uses: ./.github/actions/yarn-install
     - name: Build packages
diff --git a/.github/actions/create-release/action.yml b/.github/actions/create-release/action.yml
index ff22a0cb3a0..1d26e17e8fc 100644
--- a/.github/actions/create-release/action.yml
+++ b/.github/actions/create-release/action.yml
@@ -14,6 +14,8 @@ inputs:
 runs:
   using: composite
   steps:
+    - name: Setup node.js
+      uses: ./.github/actions/setup-node
     - name: Yarn install
       uses: ./.github/actions/yarn-install
     - name: Configure Git
diff --git a/.github/actions/maestro-ios/action.yml b/.github/actions/maestro-ios/action.yml
index 5ba4f8dc2aa..50b21597c9e 100644
--- a/.github/actions/maestro-ios/action.yml
+++ b/.github/actions/maestro-ios/action.yml
@@ -35,6 +35,8 @@ runs:
       with:
         java-version: '17'
         distribution: 'zulu'
+    - name: Setup node.js
+      uses: ./.github/actions/setup-node
     - name: Run yarn install
       uses: ./.github/actions/yarn-install
     - name: Start Metro in Debug
diff --git a/.github/actions/prepare-hermes-workspace/action.yml b/.github/actions/prepare-hermes-workspace/action.yml
index 22dbe356ee5..47953b67600 100644
--- a/.github/actions/prepare-hermes-workspace/action.yml
+++ b/.github/actions/prepare-hermes-workspace/action.yml
@@ -17,9 +17,6 @@ outputs:
 runs:
   using: composite
   steps:
-    - name: Setup node.js
-      uses: ./.github/actions/setup-node
-
     - name: Setup hermes version
       shell: bash
       id: hermes-version
@@ -67,6 +64,8 @@ runs:
           echo "HERMES_CACHED=true" >> "$GITHUB_OUTPUT"
         fi
 
+    - name: Setup node.js
+      uses: ./.github/actions/setup-node
     - name: Yarn- Install Dependencies
       if: ${{ steps.meaningful-cache.outputs.HERMES_CACHED != 'true' }}
       uses: ./.github/actions/yarn-install
diff --git a/.github/actions/test-ios-helloworld/action.yml b/.github/actions/test-ios-helloworld/action.yml
index 00f3edf02a2..0a9a6939bba 100644
--- a/.github/actions/test-ios-helloworld/action.yml
+++ b/.github/actions/test-ios-helloworld/action.yml
@@ -23,6 +23,8 @@ runs:
       uses: ./.github/actions/setup-xcode
     - name: Setup node.js
       uses: ./.github/actions/setup-node
+    - name: Run yarn install
+      uses: ./.github/actions/yarn-install
     - name: Create Hermes folder
       shell: bash
       run: mkdir -p "$HERMES_WS_DIR"
@@ -34,8 +36,6 @@ runs:
     - name: Print Downloaded hermes
       shell: bash
       run: ls -lR "$HERMES_WS_DIR"
-    - name: Run yarn
-      uses: ./.github/actions/yarn-install
     - name: Setup ruby
       uses: ruby/setup-ruby@v1
       with:
diff --git a/.github/actions/yarn-install/action.yml b/.github/actions/yarn-install/action.yml
index 7f7c7bd2bc9..cdb4a85c899 100644
--- a/.github/actions/yarn-install/action.yml
+++ b/.github/actions/yarn-install/action.yml
@@ -2,8 +2,6 @@ name: yarn-install
 runs:
   using: composite
   steps:
-    - name: Setup node.js
-      uses: ./.github/actions/setup-node
     - name: Install dependencies
       shell: bash
       run: |