From 5d76fe662affaecad74be37e8fbc1b97a8de6b13 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Mon, 9 Jun 2025 03:43:13 -0700 Subject: [PATCH] preventing future build failures (#51890) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51890 changelog: [internal] Fixing possible build failures when targets are built in different context: - Adding includes to used std functions. - Using explicit jsi namespace. - Declaring dependency. Reviewed By: javache Differential Revision: D74878821 fbshipit-source-id: 9dfd7ba94651280331be6c9fe6948fce50955589 --- .../inspector-modern/chrome/HermesRuntimeTargetDelegate.cpp | 5 +++-- .../ReactCommon/jsinspector-modern/network/NetworkReporter.h | 1 + .../android/react/renderer/components/view/NativeDrawable.h | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/react-native/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.cpp b/packages/react-native/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.cpp index 0b95f4922b2..4398431e61b 100644 --- a/packages/react-native/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.cpp +++ b/packages/react-native/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.cpp @@ -5,6 +5,7 @@ * LICENSE file in the root directory of this source tree. */ +#include #include #include "HermesRuntimeSamplingProfileSerializer.h" @@ -39,12 +40,12 @@ class HermesRuntimeSamplingProfileDelegate { : hermesRuntime_(std::move(hermesRuntime)) {} void startSampling() { - auto* hermesAPI = castInterface(makeHermesRootAPI()); + auto* hermesAPI = jsi::castInterface(makeHermesRootAPI()); hermesAPI->enableSamplingProfiler(HERMES_SAMPLING_FREQUENCY_HZ); } void stopSampling() { - auto* hermesAPI = castInterface(makeHermesRootAPI()); + auto* hermesAPI = jsi::castInterface(makeHermesRootAPI()); hermesAPI->disableSamplingProfiler(); } diff --git a/packages/react-native/ReactCommon/jsinspector-modern/network/NetworkReporter.h b/packages/react-native/ReactCommon/jsinspector-modern/network/NetworkReporter.h index 90701c412bf..bd56c6048db 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/network/NetworkReporter.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/network/NetworkReporter.h @@ -15,6 +15,7 @@ #include #include #include +#include namespace facebook::react::jsinspector_modern { diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/NativeDrawable.h b/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/NativeDrawable.h index 1c2c99dbd86..c2668f291e1 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/NativeDrawable.h +++ b/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/NativeDrawable.h @@ -7,6 +7,7 @@ #pragma once +#include #include #include #include