From 5cffb4fa009e70edaa274e7d3ebb3eb4bc1a3d13 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Thu, 24 Nov 2022 09:18:36 -0800 Subject: [PATCH] Bump AGP to 7.4.x (#35456) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/35456 Fixes #35439 There is a bug in AGP 7.3.x which is causing assets to don't be copied properly inside the final artifact: issuetracker.google.com/issues/237421684 As AGP 7.4.x is really close to release (is in Beta5, should be released stable in the next weeks) we should be fine by bumping to beta5. This also requires a bump of RNGP Changelog: [Android] [Changed] - Bump AGP to 7.4.x allow-large-files Reviewed By: cipolleschi Differential Revision: D41519549 fbshipit-source-id: 60d568a3e49798a23f1d7bf4839ab58bd5549aba --- packages/react-native-gradle-plugin/build.gradle.kts | 6 +++--- .../src/main/kotlin/com/facebook/react/ReactPlugin.kt | 6 ++++-- template/android/build.gradle | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/react-native-gradle-plugin/build.gradle.kts b/packages/react-native-gradle-plugin/build.gradle.kts index dd9a08ae099..b1b2dd61012 100644 --- a/packages/react-native-gradle-plugin/build.gradle.kts +++ b/packages/react-native-gradle-plugin/build.gradle.kts @@ -33,7 +33,7 @@ group = "com.facebook.react" dependencies { implementation(gradleApi()) - implementation("com.android.tools.build:gradle:7.3.1") + implementation("com.android.tools.build:gradle:7.4.0-beta05") implementation("com.google.code.gson:gson:2.8.9") implementation("com.google.guava:guava:31.0.1-jre") implementation("com.squareup:javapoet:1.13.0") @@ -50,8 +50,8 @@ dependencies { } java { - sourceCompatibility = JavaVersion.VERSION_1_8 - targetCompatibility = JavaVersion.VERSION_1_8 + sourceCompatibility = JavaVersion.VERSION_11 + targetCompatibility = JavaVersion.VERSION_11 } tasks.withType { diff --git a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt index b6523cdf607..152a7667e4c 100644 --- a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt +++ b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt @@ -47,8 +47,10 @@ class ReactPlugin : Plugin { configureBuildConfigFields(project) configureDevPorts(project) - project.extensions.getByType(AndroidComponentsExtension::class.java).onVariants { variant -> - project.configureReactTasks(variant = variant, config = extension) + project.extensions.getByType(AndroidComponentsExtension::class.java).apply { + onVariants(selector().all()) { variant -> + project.configureReactTasks(variant = variant, config = extension) + } } configureCodegen(project, extension, isLibrary = false) } diff --git a/template/android/build.gradle b/template/android/build.gradle index 4631930d4a5..baa44e144bb 100644 --- a/template/android/build.gradle +++ b/template/android/build.gradle @@ -15,7 +15,7 @@ buildscript { mavenCentral() } dependencies { - classpath("com.android.tools.build:gradle:7.3.1") + classpath("com.android.tools.build:gradle:7.4.0-beta05") classpath("com.facebook.react:react-native-gradle-plugin") } }