From 5c9c901d0c76f9349ab2351510ce0e7e7ba07a26 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Sun, 27 Feb 2022 22:23:48 -0800 Subject: [PATCH] Introduce DefaultValuesReactNativeConfig constant Summary: Introduce DefaultValuesReactNativeConfig constant that represents a ReactNativeConfig that always return default values I also use this constant in all the apps using fbaric that don't have a custom Mobile Config changelog: [internal] internal Reviewed By: RSNara Differential Revision: D34160478 fbshipit-source-id: 5730054fd4cc87e1fe5dc8247cc237194bf48981 --- .../react/fabric/ReactNativeConfig.java | 24 +++++++++++++++++++ .../react/uiapp/RNTesterApplication.java | 4 ++-- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/ReactNativeConfig.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/ReactNativeConfig.java index 87f563cced3..390e4ebd1be 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/ReactNativeConfig.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/ReactNativeConfig.java @@ -22,6 +22,30 @@ import com.facebook.proguard.annotations.DoNotStrip; */ @DoNotStrip public interface ReactNativeConfig { + + public final ReactNativeConfig DefaultValuesReactNativeConfig = + new ReactNativeConfig() { + @Override + public boolean getBool(@NonNull String param) { + return false; + } + + @Override + public long getInt64(@NonNull String param) { + return 0; + } + + @Override + public String getString(@NonNull String param) { + return null; + } + + @Override + public double getDouble(@NonNull String param) { + return 0; + } + }; + /** * Get a boolean param by string name. Default should be false. * diff --git a/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java b/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java index 1a393ce051d..057823d8e9f 100644 --- a/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java +++ b/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java @@ -29,8 +29,8 @@ import com.facebook.react.bridge.UIManager; import com.facebook.react.config.ReactFeatureFlags; import com.facebook.react.fabric.ComponentFactory; import com.facebook.react.fabric.CoreComponentsRegistry; -import com.facebook.react.fabric.EmptyReactNativeConfig; import com.facebook.react.fabric.FabricJSIModuleProvider; +import com.facebook.react.fabric.ReactNativeConfig; import com.facebook.react.module.model.ReactModuleInfo; import com.facebook.react.module.model.ReactModuleInfoProvider; import com.facebook.react.shell.MainReactPackage; @@ -172,7 +172,7 @@ public class RNTesterApplication extends Application implements ReactApplication reactApplicationContext, componentFactory, // TODO: T71362667 add ReactNativeConfig's support in RNTester - new EmptyReactNativeConfig(), + ReactNativeConfig.DefaultValuesReactNativeConfig, viewManagerRegistry); } });