mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Make remaining FBiOS/FB4A components export SVCs via __INTERNAL_VIEW_CONFIG
Summary: The static ViewConfig codegen generates the static ViewConfig inside the JavaScript module [under an exported constant](https://github.com/facebook/react-native/blob/a0a2958cdac767f50084c2d5bee6cf224ffb9db3/packages/react-native-codegen/src/generators/components/GenerateViewConfigJs.js#L127-L129): ``` export const __INTERNAL_VIEW_CONFIG = VIEW_CONFIG; export default NativeComponentRegistry.get(nativeComponentName, () => __INTERNAL_VIEW_CONFIG); ``` This exported constant allows us to build a test page that requires all components, and compares their static ViewConfigs with their native ViewConfig. This diff makes components with hand-written static ViewConfigs also export this __INTERNAL_VIEW_CONFIG const. Changelog: [Internal] Reviewed By: p-sun Differential Revision: D34541868 fbshipit-source-id: f55dd3f1b161038baaf84cbbf75c1f4041c34647
This commit is contained in:
committed by
Facebook GitHub Bot
parent
ec27141b93
commit
5c8d95b4e2
@@ -13,7 +13,10 @@ import type {ImageProps} from './ImageProps';
|
||||
import type {ViewProps} from '../Components/View/ViewPropTypes';
|
||||
import * as NativeComponentRegistry from '../NativeComponent/NativeComponentRegistry';
|
||||
import {ConditionallyIgnoredEventHandlers} from '../NativeComponent/ViewConfigIgnore';
|
||||
import type {HostComponent} from '../Renderer/shims/ReactNativeTypes';
|
||||
import type {
|
||||
HostComponent,
|
||||
PartialViewConfig,
|
||||
} from '../Renderer/shims/ReactNativeTypes';
|
||||
import type {
|
||||
ColorValue,
|
||||
DangerouslyImpreciseStyle,
|
||||
@@ -38,7 +41,7 @@ type Props = $ReadOnly<{
|
||||
loadingIndicatorSrc?: ?string,
|
||||
}>;
|
||||
|
||||
const ImageViewViewConfig =
|
||||
export const __INTERNAL_VIEW_CONFIG: PartialViewConfig =
|
||||
Platform.OS === 'android'
|
||||
? {
|
||||
uiViewClassName: 'RCTImageView',
|
||||
@@ -138,6 +141,9 @@ const ImageViewViewConfig =
|
||||
};
|
||||
|
||||
const ImageViewNativeComponent: HostComponent<Props> =
|
||||
NativeComponentRegistry.get<Props>('RCTImageView', () => ImageViewViewConfig);
|
||||
NativeComponentRegistry.get<Props>(
|
||||
'RCTImageView',
|
||||
() => __INTERNAL_VIEW_CONFIG,
|
||||
);
|
||||
|
||||
export default ImageViewNativeComponent;
|
||||
|
||||
Reference in New Issue
Block a user