From 5c6451247db725a213796b4d4d347178eaecf940 Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Fri, 6 Dec 2019 10:03:14 -0800 Subject: [PATCH] Make DeviceInfo extend ReactContextBaseJavaModule Summary: Changelog: [Android][Changed] - Make DeviceInfo extend ReactContextBaseJavaModule Reviewed By: PeteTheHeat Differential Revision: D18784629 fbshipit-source-id: 782b922aa14232738dc7969594b0e0f07d9241f9 --- .../react/modules/deviceinfo/DeviceInfoModule.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/DeviceInfoModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/DeviceInfoModule.java index c612182f4ce..d9972664265 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/DeviceInfoModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/DeviceInfoModule.java @@ -9,9 +9,9 @@ package com.facebook.react.modules.deviceinfo; import android.content.Context; import androidx.annotation.Nullable; -import com.facebook.react.bridge.BaseJavaModule; import com.facebook.react.bridge.LifecycleEventListener; import com.facebook.react.bridge.ReactApplicationContext; +import com.facebook.react.bridge.ReactContextBaseJavaModule; import com.facebook.react.bridge.ReactNoCrashSoftException; import com.facebook.react.bridge.ReactSoftException; import com.facebook.react.module.annotations.ReactModule; @@ -23,7 +23,7 @@ import java.util.Map; /** Module that exposes Android Constants to JS. */ @ReactModule(name = DeviceInfoModule.NAME) -public class DeviceInfoModule extends BaseJavaModule +public class DeviceInfoModule extends ReactContextBaseJavaModule implements LifecycleEventListener, TurboModule { public static final String NAME = "DeviceInfo"; @@ -32,12 +32,15 @@ public class DeviceInfoModule extends BaseJavaModule private float mFontScale; public DeviceInfoModule(ReactApplicationContext reactContext) { - this((Context) reactContext); + super(reactContext); + DisplayMetricsHolder.initDisplayMetricsIfNotInitialized(reactContext); + mFontScale = reactContext.getResources().getConfiguration().fontScale; mReactApplicationContext = reactContext; mReactApplicationContext.addLifecycleEventListener(this); } public DeviceInfoModule(Context context) { + super(null); mReactApplicationContext = null; DisplayMetricsHolder.initDisplayMetricsIfNotInitialized(context); mFontScale = context.getResources().getConfiguration().fontScale;