mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
AndroidTextInput uses default padding from Android theme
Summary: For backwards-compatibility with Paper, we're implementing a feature in Fabric that will allow TextInputs to use the default padding from the theme in Android. Note that this uses some pretty ugly hacks that probably shouldn't be used inside of components at all: looking directly at rawProps, overriding props/Yoga styles in the component descriptor, etc. I would (personally) really like to kill this feature entirely unless and until we can find a more elegant solution. Changelog: [Internal] TextInputs are still not pixel-perfect with Paper, but they're much closer, and the underline visual glitchiness is no longer an issue. Reviewed By: mdvacca Differential Revision: D20109605 fbshipit-source-id: 543282843e0a9f03a504d72d7a014431099bd64c
This commit is contained in:
committed by
Facebook Github Bot
parent
6ea963de6a
commit
5be86695a3
+5
-1
@@ -144,7 +144,11 @@ void AndroidTextInputShadowNode::updateStateIfNeeded() {
|
||||
getConcreteProps().paragraphAttributes,
|
||||
defaultTextAttributes,
|
||||
ShadowView(*this),
|
||||
textLayoutManager_});
|
||||
textLayoutManager_,
|
||||
state.defaultThemePaddingStart,
|
||||
state.defaultThemePaddingEnd,
|
||||
state.defaultThemePaddingTop,
|
||||
state.defaultThemePaddingBottom});
|
||||
}
|
||||
|
||||
#pragma mark - LayoutableShadowNode
|
||||
|
||||
Reference in New Issue
Block a user