Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Split JavaSJExecutor and ProxyExecutorException into their own file

Browse Source 
Summary: This makes the exception a nested class of the interface,
which eliminates the dependency of DevSupportManager on
ProxyJavaScriptExecutor.
public

Reviewed By: astreet

Differential Revision: D2651252

fb-gh-sync-id: 99de1c308b9bce717ab749c4e239d2773a920e1f
This commit is contained in:
Marc Horowitz
2015-11-20 12:29:20 -08:00
committed by facebook-github-bot-6
parent 67209e6396
commit 5b6b5a64d1
8 changed files with 69 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManager.java
+1 -1
View File
@@ -541,7 +541,7 @@ public class DevSupportManager implements NativeModuleCallExceptionHandler {
@Override
public void run() {
mReactInstanceCommandsHandler.onReloadWithJSDebugger(
new ProxyJavaScriptExecutor(webSocketJSExecutor));
webSocketJSExecutor);
}
});
}
ReactAndroid/src/main/java/com/facebook/react/devsupport/ReactInstanceDevCommandsHandler.java
+2 -2
View File
@@ -9,7 +9,7 @@
package com.facebook.react.devsupport;
import com.facebook.react.bridge.ProxyJavaScriptExecutor;
import com.facebook.react.bridge.JavaJSExecutor;
/**
* Interface used by {@link DevSupportManager} for requesting React instance recreation
@@ -20,7 +20,7 @@ public interface ReactInstanceDevCommandsHandler {
/**
* Request react instance recreation with JS debugging enabled.
*/
void onReloadWithJSDebugger(ProxyJavaScriptExecutor proxyExecutor);
void onReloadWithJSDebugger(JavaJSExecutor proxyExecutor);
/**
* Notify react instance manager about new JS bundle version downloaded from the server.