From 5ae6f6be25becd9674538df20e62b700155e0d01 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 2 May 2025 12:22:32 -0700 Subject: [PATCH] Cleanup and document ReactUnimplementedView (#51063) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51063 Cleanup and document ReactUnimplementedView changelog: [internal] internal Reviewed By: rshest, cortinico Differential Revision: D74036571 fbshipit-source-id: 75077914697cac56743c99fba7d7cdccad5c828a --- .../ReactUnimplementedView.kt | 21 +++++++++++-------- .../ReactUnimplementedViewManager.kt | 10 +++++---- 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedView.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedView.kt index 1f9d2f58625..2e76c1d1217 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedView.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedView.kt @@ -12,26 +12,29 @@ import android.graphics.Color import android.view.Gravity import android.widget.LinearLayout import androidx.appcompat.widget.AppCompatTextView +import com.facebook.react.common.build.ReactBuildConfig internal class ReactUnimplementedView(context: Context) : LinearLayout(context) { - private val textView: AppCompatTextView + private val textView: AppCompatTextView = AppCompatTextView(context) init { - textView = AppCompatTextView(context) - textView.layoutParams = - LinearLayout.LayoutParams( - LinearLayout.LayoutParams.WRAP_CONTENT, LinearLayout.LayoutParams.MATCH_PARENT) + textView.layoutParams = LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.MATCH_PARENT) textView.setGravity(Gravity.CENTER) textView.setTextColor(Color.WHITE) + textView.text = "" - setBackgroundColor(0x55ff0000) - setGravity(Gravity.CENTER_HORIZONTAL) - setOrientation(LinearLayout.VERTICAL) + if (ReactBuildConfig.DEBUG) { + setBackgroundColor(0x55ff0000) + } + gravity = Gravity.CENTER_HORIZONTAL + orientation = VERTICAL addView(textView) } internal fun setName(name: String) { - textView.setText("'$name' is not Fabric compatible yet.") + if (ReactBuildConfig.DEBUG) { + textView.text = "'$name' is not registered." + } } } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.kt index e4632edad31..3c43a7d091f 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.kt @@ -15,7 +15,10 @@ import com.facebook.react.uimanager.annotations.ReactProp import com.facebook.react.viewmanagers.UnimplementedNativeViewManagerDelegate import com.facebook.react.viewmanagers.UnimplementedNativeViewManagerInterface -/** ViewManager for [ReactUnimplementedView] to represent a component that is not yet supported. */ +/** + * ViewManager that renders [ReactUnimplementedView] to represent a component that is not properly + * implemented or registered. + */ @ReactModule(name = ReactUnimplementedViewManager.REACT_CLASS) internal class ReactUnimplementedViewManager : ViewGroupManager(), @@ -32,9 +35,8 @@ internal class ReactUnimplementedViewManager : override fun getName(): String = REACT_CLASS @ReactProp(name = "name") - override fun setName(view: ReactUnimplementedView, name: String?): Unit { - view.setName(name ?: "") - } + override fun setName(view: ReactUnimplementedView, name: String?): Unit = + view.setName(name ?: "") internal companion object { const val REACT_CLASS: String = "UnimplementedNativeView"