Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Differentiate between Fabric and non-Fabric UIManager logs

Browse Source 
Summary:
Both the UIManagers use ReactConstants.TAG currently, so certain logs are ambiguous. Use FabricUIManager's tag instead for all logs to disambiguate.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D19945587

fbshipit-source-id: 0a9d62b5c0276688b2ad3acf8d893b523c26560a
This commit is contained in:
Joshua Gross
2020-02-18 00:25:37 -08:00
committed by Facebook Github Bot
parent 40646e8418
commit 5aae380f2d
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
+2 -5
View File
@@ -41,7 +41,6 @@ import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.UIManager;
import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.common.ReactConstants;
import com.facebook.react.config.ReactFeatureFlags;
import com.facebook.react.fabric.events.EventBeatManager;
import com.facebook.react.fabric.events.EventEmitterWrapper;
@@ -813,9 +812,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
@ThreadConfined(UI)
public void doFrameGuarded(long frameTimeNanos) {
if (!mIsMountingEnabled || mDestroyed) {
FLog.w(
ReactConstants.TAG,
"Not flushing pending UI operations because of previously thrown Exception");
FLog.w(TAG, "Not flushing pending UI operations because of previously thrown Exception");
return;
}
@@ -826,7 +823,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
dispatchMountItems();
} catch (Exception ex) {
FLog.i(ReactConstants.TAG, "Exception thrown when executing UIFrameGuarded", ex);
FLog.i(TAG, "Exception thrown when executing UIFrameGuarded", ex);
stop();
throw ex;
} finally {