From 596dfcc44c8d9f79e6a0429f3256c69d6bf2fbed Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Wed, 27 Sep 2023 15:54:04 -0700 Subject: [PATCH] Remove dead code for Android onLayout events (#39645) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39645 Removes some dead code related to emitting OnLayout evennts in Paper. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D49626884 fbshipit-source-id: c02f3345f0f50be00aa09630410a5ac55ab30773 --- .../react/uimanager/UIViewOperationQueue.java | 41 ------------------- 1 file changed, 41 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIViewOperationQueue.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIViewOperationQueue.java index de3ca5db4f1..73bb4ac0be2 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIViewOperationQueue.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIViewOperationQueue.java @@ -94,41 +94,6 @@ public class UIViewOperationQueue { } } - private final class EmitOnLayoutEventOperation extends ViewOperation { - - private final int mScreenX; - private final int mScreenY; - private final int mScreenWidth; - private final int mScreenHeight; - - public EmitOnLayoutEventOperation( - int tag, int screenX, int screenY, int screenWidth, int screenHeight) { - super(tag); - mScreenX = screenX; - mScreenY = screenY; - mScreenWidth = screenWidth; - mScreenHeight = screenHeight; - } - - @Override - public void execute() { - UIManagerModule uiManager = mReactApplicationContext.getNativeModule(UIManagerModule.class); - - if (uiManager != null) { - uiManager - .getEventDispatcher() - .dispatchEvent( - OnLayoutEvent.obtain( - -1 /* SurfaceId not used in classic renderer */, - mTag, - mScreenX, - mScreenY, - mScreenWidth, - mScreenHeight)); - } - } - } - private final class UpdateInstanceHandleOperation extends ViewOperation { private final long mInstanceHandle; @@ -767,12 +732,6 @@ public class UIViewOperationQueue { mOperations.add(new UpdatePropertiesOperation(reactTag, props)); } - public void enqueueOnLayoutEvent( - int tag, int screenX, int screenY, int screenWidth, int screenHeight) { - mOperations.add( - new EmitOnLayoutEventOperation(tag, screenX, screenY, screenWidth, screenHeight)); - } - public void enqueueUpdateLayout( int parentTag, int reactTag, int x, int y, int width, int height) { mOperations.add(new UpdateLayoutOperation(parentTag, reactTag, x, y, width, height));