From 595f5ac64d2a37e5ae95cea95e95fdbe0300a5b7 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Mon, 4 Nov 2019 14:24:46 -0800 Subject: [PATCH] Fix Collapsing of Delete-Create mounting instructions Summary: This diff fixes the Collapsing of Delete-Create mounting instructions algorithm. By mistake I switch the conditions before landing the original diff. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D18306616 fbshipit-source-id: 50cd8ca67adcaf172ce51896df684fed270b2d51 --- .../src/main/java/com/facebook/react/fabric/jni/Binding.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp index e47befe09cc..5dfcd760eb3 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp @@ -581,9 +581,9 @@ void Binding::schedulerDidFinishTransaction( } else if (mutation.type == ShadowViewMutation::Create) { int tag = mutation.oldChildShadowView.tag; if (createAndDeleteTagsToProcess.find(tag) != createAndDeleteTagsToProcess.end()) { - createAndDeleteTagsToProcess.erase(tag); - } else { createAndDeleteTagsToProcess.insert(tag); + } else { + createAndDeleteTagsToProcess.erase(tag); } } }